LoRAWAN: volatile bool -> atomic_flag #9245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kjbracey-arm, thank you for your changes. |
kjbracey
force-pushed
the
lorawan_atomic_flag
branch
from
26db569 to
cd7f888
Compare
0xc0170
approved these changes
Jan 3, 2019
AnttiKauppila
approved these changes
Jan 3, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 1 test jobs failed Failed test jobs:
|
|
@kjbracey-arm Please take a look at the unit tests. They were not happy... |
kjbracey
force-pushed
the
lorawan_atomic_flag
branch
from
cd7f888 to
9f26ab9
Compare
|
Tests hopefully cleared. |
|
CI started |
Test run: FAILEDSummary: 1 of 1 test jobs failed Failed test jobs:
|
|
Looks like unittest failure does not propagate results to artifacts, will report this as an issue For the errors, still reports undefined references |
|
Note, created internal ticket MBEDOSTEST-427 for unittests being in artifacts if fail |
Now we have a proper atomic flag API, use it rather than a volatile cheat.
kjbracey
force-pushed
the
lorawan_atomic_flag
branch
from
9f26ab9 to
6f757a5
Compare
|
Try again... |
|
CI restarted |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Test restarted (CI script failure) |
hasnainvirk
pushed a commit
to hasnainvirk/mbed-os
that referenced
this pull request
Feb 5, 2019
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
AnttiKauppila
pushed a commit
to AnttiKauppila/mbed-os
that referenced
this pull request
May 8, 2019
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
AnttiKauppila
pushed a commit
to AnttiKauppila/mbed-os
that referenced
this pull request
Aug 30, 2019
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
AnttiKauppila
pushed a commit
to AnttiKauppila/mbed-os
that referenced
this pull request
Sep 2, 2019
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
AnttiKauppila
pushed a commit
to AnttiKauppila/mbed-os
that referenced
this pull request
Oct 29, 2019
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
AnttiKauppila
pushed a commit
that referenced
this pull request
Oct 30, 2019
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
AnttiKauppila
pushed a commit
to AnttiKauppila/mbed-os
that referenced
this pull request
Jan 9, 2020
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
AnttiKauppila
pushed a commit
that referenced
this pull request
Jan 9, 2020
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
AnttiKauppila
pushed a commit
that referenced
this pull request
Feb 6, 2020
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
slothdnk
pushed a commit
to slothdnk/mbed-os
that referenced
this pull request
Sep 12, 2020
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
Lljiro
pushed a commit
to Lljiro/mbed-os
that referenced
this pull request
Mar 17, 2021
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
paul-szczepanek-arm
pushed a commit
to paul-szczepanek-arm/mbed-os
that referenced
this pull request
Jun 25, 2021
_rx_ready boolean is not used anymore. We set/unset it using core util atomic flag set test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we have a proper atomic flag API, use it rather than a volatile cheat.
More in my "eliminate volatile" quest.
Pull request type