FLASHIAP test: skip test if test region overlaps code #9257
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeromecoutant, thank you for your changes. |
0xc0170
reviewed
Jan 7, 2019
| @@ -220,6 +222,9 @@ void flashiap_timing_test() | |||
| utest_printf("\nFlash timing:\n"); | |||
| uint32_t sector_size = flash_device.get_sector_size(end_address - 1UL); | |||
| uint32_t base_address = end_address - sector_size; | |||
| utest_printf("ROM ends at 0x%lx, test starts at 0x%lx\n", FLASHIAP_APP_ROM_END_ADDR, base_address); | |||
| TEST_SKIP_UNLESS_MESSAGE(base_address >= FLASHIAP_APP_ROM_END_ADDR, "Test skipped. Test region overlaps code."); | |||
There was a problem hiding this comment.
You are also adding some debug prints , not only skip test?
There was a problem hiding this comment.
I can remove them, but it's practical in case of test skip to understand.
There was a problem hiding this comment.
I was referring to the commit message and PR title (does not cover adding debug msg). Otherwise looks fine to me
|
Any update ? |
|
Added storage team to review instead of core. Please review |
0xc0170
approved these changes
Jan 16, 2019
|
CI started |
Test run: SUCCESSSummary: 9 of 9 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test region check was made for all test cases except "FlashIAP - timing" one
Pull request type