[API] Added option to modify RTC source #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially from Karls question here: http://developer.mbed.org/questions/6337/setTime-and-time-exported-with-__weak-fo/#answer6545?compage=1#c15936. Currently the C time functions only work with internal RTC. Sometimes you either want to use an external one, or your target does not even have an internal RTC. I added function attach_rtc(...) where the default functions can be overridden at runtime.
|
Your branch name: lookmartinImadeanewbranch 😆 |
| if (_rtc_read != NULL) { | ||
| t = _rtc_read(); | ||
| } else { | ||
| t = 0; |
There was a problem hiding this comment.
You can leave uninitialized variable behind:
time_t t = 0;
if (_rtc_read != NULL) {
t = _rtc_read();
}There was a problem hiding this comment.
I guess bit cleaner code, and tiny, tiny, bit slower. If that is preferred I will change it.
|
Did some changes. |
0xc0170
added a commit
that referenced
this pull request
Mar 9, 2015
Add option to modify RTC source for time functions (using func pointers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially from Karls question here:
http://developer.mbed.org/questions/6337/setTime-and-time-exported-with-__weak-fo/#answer6545?compage=1#c15936.
Currently the C time functions only work with internal RTC. Sometimes
you either want to use an external one, or your target does not even
have an internal RTC. I added function attach_rtc(...) where the default
functions can be overridden at runtime.
Verified it to work properly with LPC1768/LPC11u24, both with and without DS1307 RTC connected and used as source for time. I don't think the init and isenabled functions are really important to have, but you can just set them as NULL (did so myself when testing).