Configuration options for STM_EMAC buffer counts

[mtomczykmobica]

Description

Configuration options for STM_EMAC buffer counts.

Add configurable options for STM_EMAC buffer. For all STM_EMAC board targets added mbed_lib.jeson with configurable: eth-rxbufnb and eth-txbufnb used in stm32f1xx_hal_conf.h.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo

[ciarmcom]

@mtomczykmobica, thank you for your changes.
@SeppoTakalo @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

[jeromecoutant]

I would propose to use the same lib name for all.

"name": "stm32-emac",

Thx

[jeromecoutant]

What is "ONME-3949" ?
Thx

[mtomczykmobica]

What is "ONME-3949" ?
Thx

Internal Jira ticket number.

[0xc0170]

Is it that important to have it in the title ? Fine to be referenced in the commit msg or description here, isn't that sufficient ?

[jeromecoutant]

Or use the github issue number behind this internal reference....

[mtomczykmobica]

Is it that important to have it in the title ? Fine to be referenced in the commit msg or description here, isn't that sufficient ?

ok, changed.

[0xc0170]

@ARMmbed/team-st-mcd Please review

[jeromecoutant]

@ARMmbed/team-st-mcd Please review

I have already reviewed it and propose to use the same lib name for all.

"name": "stm32-emac",

Thx

[cmonr]

@mtomczykmobica Any updates?

[mtomczykmobica]

@jeromecoutant I prefer to leave different names for different targets.

[SeppoTakalo]

After a another thought on this,
Can we instead move the mbed_lib.json up for couple of levels so that all stm32-emac drivers share one .lib file?
Then all variables can have same name and be overridden by target.

So basically this whole change would be
features/netsocket/emac-drivers/TARGET_STM_EMAC/mbed_lib.json:

{
    "name": "stm32-emac",
    "config": {
        "eth-rxbufnb": 4,
        "eth-txbufnb": 4
    },
    "target_overrides": {
        "NUCLEO_F207ZG": {
            "eth-rxbufnb": 1,
            "eth-txbufnb": 4
        }
    }
}

And within the header files, just use the generic name:

#define ETH_RXBUFNB                       MBED_CONF_STM32_EMAC_ETH_RXBUFNB

No need for if-def as the mbed_lib.json always provides values for those.

[mtomczykmobica]

@SeppoTakalo , @jeromecoutant requested changes added.

[0xc0170]

Waiting for @ARMmbed/team-st-mcd review

[0xc0170]

CI started

[mbed-ci]

Test run: FAILED

Summary: 6 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
• jenkins-ci/mbed-os-ci_mbed2-build-ARM
• jenkins-ci/mbed-os-ci_mbed2-build-IAR
• jenkins-ci/mbed-os-ci_build-IAR
• jenkins-ci/mbed-os-ci_build-ARM
• jenkins-ci/mbed-os-ci_build-GCC_ARM

[mtomczykmobica]

Fixes for builds error.

[0xc0170]

CI was restarted

[mbed-ci]

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts