Add FLASH support to TARGET_MAX32620C and brd targets #9316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentcooke
force-pushed
the
add_flash_MAX32620FTHR
branch
from
e14d562 to
ec3f309
Compare
cmonr
reviewed
Jan 10, 2019
| @@ -16,7 +16,7 @@ define region RAM_region = mem:[from __region_RAM_start__ to __region_RAM | |||
|
|
|||
| /* Stack and Heap */ | |||
| define symbol __size_cstack__ = 0x1000; | |||
| define symbol __size_heap__ = 0x4000; | |||
| define symbol __size_heap__ = 0xF000; | |||
There was a problem hiding this comment.
That is quite the jump in heap allocation.
Though it looks like this target specific, so that should be fine.
Please resolve the conflict via rebase |
0xc0170
approved these changes
Jan 15, 2019
bentcooke
force-pushed
the
add_flash_MAX32620FTHR
branch
from
ec3f309 to
a588dc3
Compare
bentcooke
force-pushed
the
add_flash_MAX32620FTHR
branch
from
dfe5573 to
95a050b
Compare
|
rebased to resolve conflict |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
This is on top of #9092 scheduled for 5.12 so bumping this one also. |
adbridge
added
release-version: 5.12.0-rc1
release-version: 5.11.3
and removed
release-version: 5.11.3
release-version: 5.12.0-rc1
labels
|
OK now hand patched across to mbed-os-5.11.3 release candidate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logs with passing GT flash tests:
flashtests-MAX32620FTHR-ARM.log
flashtests-MAX32620FTHR-IAR.log
flashtests-MAX32620FTHR-GCC_ARM.log
Pull request type