Skip to content

tools/importer script changes #9319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2019
Merged

tools/importer script changes #9319

merged 1 commit into from
Jan 10, 2019

Conversation

mikisch81
Copy link
Contributor

Description

Small fixes to the tools/importer.py mainly for debug prints and to prepare it to be able to also import TF-M sources.

Pull request type

[X] Fix
[] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mikisch81
Copy link
Contributor Author

@ARMmbed/mbed-os-tools

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@@ -81,7 +81,7 @@ def get_curr_sha(repo_path):
cwd = os.getcwd()
os.chdir(abspath(repo_path))

cmd = "git log --pretty=format:%h -n 1"
cmd = ['git', 'log', '--pretty=format:%h', '-n', '1']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmonr
Copy link
Contributor

cmonr commented Jan 10, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 28d5477 into ARMmbed:master Jan 10, 2019
@cmonr cmonr removed the needs: CI label Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants