Skip to content

SDBlockDevice docs update #9329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2019
Merged

SDBlockDevice docs update #9329

merged 2 commits into from
Jan 14, 2019

Conversation

juhaylinen
Copy link
Contributor

Description

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@juhaylinen
Copy link
Contributor Author

@melwee01 please review

melwee01
melwee01 approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@melwee01 melwee01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple small changes myself.

@0xc0170 0xc0170 requested a review from a team January 10, 2019 13:25
davidsaada
davidsaada approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@NirSonnenschein
Copy link
Contributor

starting CI

@mbed-ci
Copy link

mbed-ci commented Jan 13, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170 0xc0170 merged commit ebf3a19 into ARMmbed:master Jan 14, 2019
@juhaylinen juhaylinen deleted the sdblockdevice-doc branch January 14, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@davidsaada davidsaada davidsaada approved these changes

@melwee01 melwee01 melwee01 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@juhaylinen @NirSonnenschein @mbed-ci @0xc0170 @davidsaada @melwee01 @cmonr