Skip to content

unittest: remove cellular driver L3IP stub #9337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

unittest: remove cellular driver L3IP stub #9337

merged 1 commit into from
Jan 17, 2019

Conversation

tymoteuszblochmobica
Copy link
Contributor

@tymoteuszblochmobica tymoteuszblochmobica commented Jan 10, 2019 •
edited
Loading

Description

Removed cellular L3IP stub driver.
It will be added to Greentea tests if needed

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x ] Test update
[ ] Breaking change

Reviewers

@tymoteuszblochmobica
Copy link
Contributor Author

@SeppoTakalo please review
@mikaleppanen please review

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 10, 2019

@SeppoTakalo please review
@mikaleppanen please review

Use Reviewers section in the first comment when opening PR, the bot will assign them as reviewers automatically

@ciarmcom ciarmcom requested review from a team January 10, 2019 16:00
@ciarmcom
Copy link
Member

@tymoteuszblochmobica, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title Removed cellular driver L3IP stub unittest: remove cellular driver L3IP stub Jan 11, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

I am checking astyle failure, should not be any. Will fix

Reason for this is that no unittest needed for the driver ?

@tymoteuszblochmobica
Copy link
Contributor Author

tymoteuszblochmobica commented Jan 11, 2019 via email

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

astyle job will be fixed via #9346 (this will need to be rebased once that gets in)

@cmonr
Copy link
Contributor

cmonr commented Jan 11, 2019

Rebase when able.

@tymoteuszblochmobica
Copy link
Contributor Author

Rebased

@mbed-ci
Copy link

mbed-ci commented Jan 14, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@timurh01
Copy link
Contributor

Greentea test restarted in CI. Failure reason unrelated to this PR.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 15, 2019

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2019

CI job was aborted, 5.11.2 RC candidate is in the CI. We will restart it as soon as 5.11.2 RC is ready

@cmonr
Copy link
Contributor

cmonr commented Jan 16, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 16, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@cmonr cmonr removed the needs: CI label Jan 16, 2019
@cmonr cmonr merged commit 92a5f2f into ARMmbed:master Jan 17, 2019
@tymoteuszblochmobica tymoteuszblochmobica deleted the removecellular branch April 25, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tymoteuszblochmobica @0xc0170 @ciarmcom @cmonr @mbed-ci @timurh01 @SeppoTakalo