Skip to content

[Do Not Merge] Astyle fix test #9348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Jan 11, 2019

Description

A test of #9346 with a PR against a non-master branch.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Consolidated efforts from PR ARMmbed#9336.

Previous job's env vars would not be populated correctly if the base branch of a PR was not master.
Corected by pulling remaining respository information to perform comparison between read-only instance of PR and base branch.
@cmonr cmonr requested a review from a team January 11, 2019 04:37
@cmonr cmonr force-pushed the test-astyle-fix-against-feature_branch branch from b089fa8 to 06767cc Compare January 11, 2019 04:56
@cmonr
Copy link
Contributor Author

cmonr commented Jan 11, 2019

The base branch is a bit behind master:

Branch Name                          Ahead  Behind  Last Commit  Last Rebase
feature-hal-spec-usb-device          140    263     2019-01-09   2018-12-19

Cherry-picked additional Travis CI fix for demonstration purposes.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

Passed, looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants