Skip to content

Fix for asserion failing in BLE::callDispatcher with gcc debug profile. #9365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fix for asserion failing in BLE::callDispatcher with gcc debug profile. #9365

merged 1 commit into from
Jan 17, 2019

Conversation

lrusinowicz
Copy link
Contributor

Initialization of Timeout object used in BLE::callDispatcher() contains critical section inside a constructor. It's initialization inside a critical section caused assertion failing under "debug" profile.

Description

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@lrusinowicz
Moved nextTimeout variable out of critical section in BLE::callDispat…
f294447 
…cher.

Initialization of Timeout object contains critical section inside constructor. Initialization inside critical section caused assertion failing under "debug" profile.
@ciarmcom ciarmcom requested review from a team January 14, 2019 12:00
@ciarmcom
Copy link
Member

@lrusinowicz, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

pan-
pan- approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 15, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2019

CI job was aborted, 5.11.2 RC candidate is in the CI. We will restart it as soon as 5.11.2 RC is ready

@cmonr
Copy link
Contributor

cmonr commented Jan 16, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit d0665c8 into ARMmbed:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lrusinowicz @ciarmcom @0xc0170 @mbed-ci @cmonr @pan-