Release candidate for mbed-os-5.11.2 #9370

adbridge · 2019-01-14T13:49:40Z

No description provided.

…or / assert when allocation fails.

Issue was seen with below example EventQueue q1; EventQueue q2; void main() { while( true ) { q1.chain( &q2 ); // Chain q2 to q1 q1.chain( NULL ); // Remove chain from q1 //This second step should free the memory from the chained q2 event. } } Memory allocated from q1 slab was freed for q2, which will result in memory leak.

When accessing non-secure ram and flash r1 was actually used by the calling function. Change to a callee saved register.

Use r3 instead of r4 Co-Authored-By: orenc17 <[email protected]>

Space needed between 2 string literals [Error] fopen.cpp@204,97: [Pe2486]: user-defined literal operator not found

`size` is part of std library since c++17, and results in build errors for IAR 8.x. https://en.cppreference.com/w/cpp/iterator/size

For binary compatibility with ARMC5, use the hard ABI variant whenever we have FP hardware - this is ARMC5's default behaviour, which we do not override. Cortex-M4F was already using hard; this brings M7F and M33F into line.

Replace Mutex with PlatformMutex which supports RTOS-absent

Configure RTS pin outout to active low when RTS is disabled. This allows the peer to be able to send data if its CTS is still enabled.

…efault values are use

This PR addresses the issue of #8903. A new boolean variable 'debug' is added to turn off the display of debugging message (by default). It can be turned on when needed. Description 1. Add new boolean parameter ‘debug’ in function ‘RTWInterface’ in file "RTWInterface.h". 2. Add conditional statement to enable/disable variable ‘GlobalDebugEnable’ in file "RTWInterface.h" to control whether debugging message should be displayed.

Change the use of the local static function `mbedtls_zeroize()` to the Mbed TLS platform function `mbedtls_platform_zeroize()`.

In case of unusing RTOS, IRQ handler executes "while(1)" and it causes a program freeze. Therefore, I revised this processing. Also I added the heap setting processing and set the align to 8 byte.

In case of unusing RTOS, IRQ handler executes "while(1)" and it causes a program freeze. Therefore, I revised this processing.

In case of unusing RTOS, there is no processing against IRQ handler and it causes a linker error. Therefore, I added this processing with WEAK attribute. Also I added cmain.S file at cmsis/TARGET_CORTEX_A folder.

0xc0170 · 2019-01-14T15:27:09Z

My local test run

pytest tools\test
============================= test session starts =============================
platform win32 -- Python 2.7.15, pytest-3.3.2, py-1.5.2, pluggy-0.6.0
rootdir: C:\Code\mbed-os, inifile:
plugins: hypothesis-3.44.16
collected 162 items

tools\test\detect_targets_test.py .....                                  [  3%]
tools\test\build_api\build_api_test.py ...FF..                           [  7%]
tools\test\config\config_test.py ....................................... [ 31%]
.                                                                        [ 32%]
tools\test\memap\memap_test.py ........................                  [ 46%]
tools\test\memap\parse_test.py .....                                     [ 50%]
tools\test\run_icetea\run_icetea_test.py .......                         [ 54%]
tools\test\run_icetea\run_icetea_unit_test.py ..............             [ 62%]
tools\test\spm\test_generate_partition_code.py ......................... [ 78%]
....................                                                     [ 90%]
tools\test\targets\target_test.py ...                                    [ 92%]
tools\test\toolchains\api_test.py .........                              [ 98%]
tools\test\toolchains\arm_support_test.py ...                            [100%]

Updated hypothesis and others pip install -U pytest pylint hypothesis mock coverage coveralls and got different test results:

pytest tools\test
============================= test session starts =============================
platform win32 -- Python 2.7.15, pytest-4.1.1, py-1.5.2, pluggy-0.8.1
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('C:\\Code\\mbed-os\\.hypothesis\\examples')
rootdir: C:\Code\mbed-os, inifile:
plugins: hypothesis-4.0.0
collected 162 items

tools\test\detect_targets_test.py .....                                  [  3%]
tools\test\build_api\build_api_test.py ...FF..                           [  7%]
tools\test\config\config_test.py ....................................... [ 31%]
.                                                                        [ 32%]
tools\test\memap\memap_test.py ........................                  [ 46%]
tools\test\memap\parse_test.py .....                                     [ 50%]
tools\test\run_icetea\run_icetea_test.py .......                         [ 54%]
tools\test\run_icetea\run_icetea_unit_test.py ..............             [ 62%]
tools\test\spm\test_generate_partition_code.py ......................... [ 78%]
....................                                                     [ 90%]
tools\test\targets\target_test.py ...                                    [ 92%]
tools\test\toolchains\api_test.py ...F....F                              [ 98%]
tools\test\toolchains\arm_support_test.py FFF                            [100%]

cc @ARMmbed/mbed-os-tools

cmonr · 2019-01-14T19:53:50Z

Note: Fix is now in master (#9371), but we're still waiting on a fix for Cloud Client.

Update to v4.x breaks tools, will need to be addressed separately.

0xc0170 · 2019-01-15T08:32:05Z

Travis fix added to 5.11.2

0xc0170 · 2019-01-15T08:39:46Z

CI started (while we might expect one or two fixes)

mbed-ci · 2019-01-15T12:12:59Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

0xc0170 · 2019-01-15T12:25:35Z

Note, @ARMmbed/mbed-os-storage @JanneKiiskila The 5.11.2 RC is ready , waiting for your +1 that this is good to go

JanneKiiskila · 2019-01-15T12:49:02Z

Ok from our point of view. We have one more issue for urgent fix, but that's probably not going to make this one anyway. (edit: So happy to be wrong!)

SeppoTakalo · 2019-01-15T13:25:46Z

https://jira.arm.com/browse/ONME-4127

MTB_WISE_1530 and MTB_USI_WM_BN_BM_22 Hardfaults when running Mbed OS socket tests. However needs more studying.

This issue seems to be same for all WICED based WiFi boards when running against Arm compiler.
GCC works.

0xc0170 · 2019-01-15T13:46:08Z

We are waiting for @ARMmbed/mbed-os-storage to confirm (one patch still might come)

adbridge · 2019-01-15T14:01:34Z

https://jira.arm.com/browse/ONME-4127
This issue seems to be same for all WICED based WiFi boards when running against Arm compiler.
GCC works.

As there is a working compiler we would not consider this a blocker for the 5.11.2 release. It can be added to the known issues for the release. @SeppoTakalo could you please drop me an email with a quick summary of the issue that is suitable for putting in the release note as a known issue ?

MBRBlockDevice: When partitioning, clear the rest of first erase unit

cmonr · 2019-01-16T04:51:01Z

#9384 merged, and cherry-picked into release-candidate.

cmonr · 2019-01-16T04:55:51Z

CI started

cmonr · 2019-01-16T05:27:24Z

Note: Travis CI issue is will be resolved with this PR: #9391

Running CI to make sure cherry-picked PR passes with RC, and to give @jannehekkala and team more time to test.

JanneKiiskila · 2019-01-16T06:30:55Z

Test PRs on-going.

mbed-ci · 2019-01-16T07:21:26Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

JanneKiiskila · 2019-01-16T07:51:59Z

Nucleo F429ZI ethernet doesn't work after firmware update, it can't connect for some reason. @teetak01 has already raised a on bug on this.

2019-01-16T06:41:09.017Z | D1 <<< DutThread: Error occurred : MbedCloudClient::ConnectDnsResolvingFailed
2019-01-16T06:41:09.017Z | D1 <<< DutThread: Error code : 12
2019-01-16T06:41:09.017Z | D1 <<< DutThread: Error details : DnsResolvingFailed

Error ref: ONME-4124. @SeppoTakalo - can we get some runtime for this?

0xc0170 · 2019-01-16T15:03:20Z

Travis fix in

adbridge · 2019-01-16T15:07:10Z

ci started

mbed-ci · 2019-01-16T18:11:38Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

0xc0170 · 2019-01-16T18:18:37Z

5.11.2 is ready 🎉

Olli-Pekka Puolitaival and others added 30 commits January 14, 2019 13:06

More static place for astyle

4a0b2c1

Check is allocation in event queue was success or not, and report err…

75c8c3b

…or / assert when allocation fails.

Return error in case chaining fails

85b7537

Update the unit test stubs as per API changes

a8fde95

Fix SPM HAL test

e875e5d

When accessing non-secure ram and flash r1 was actually used by the calling function. Change to a callee saved register.

Run the non-secure cases first

8e20890

Update TESTS/mbed_hal/spm/main.cpp

cc5e905

Use r3 instead of r4 Co-Authored-By: orenc17 <[email protected]>

Fix ticker_read_us() race condition.

503f2fc

Resolve string literal error

ee64d82

Space needed between 2 string literals [Error] fopen.cpp@204,97: [Pe2486]: user-defined literal operator not found

Resolved warning: variable declared but never referenced

95d4353

Resolved: [Error] main.cpp@115,34: [Pe266]: "size" is ambiguous

7dda22f

`size` is part of std library since c++17, and results in build errors for IAR 8.x. https://en.cppreference.com/w/cpp/iterator/size

Greentea tests ignore bind returning UNSUPPORTED

595e487

ARMC6: Use float-abi=hard

2789854

For binary compatibility with ARMC5, use the hard ABI variant whenever we have FP hardware - this is ARMC5's default behaviour, which we do not override. Cortex-M4F was already using hard; this brings M7F and M33F into line.

Remove unnecessary mbed_rtos_storage.h in crypto_misc.cpp

fd0ff1f

Fix crypto_misc.cpp compile error with RTOS-absent

8eef604

Replace Mutex with PlatformMutex which supports RTOS-absent

Refine MBED_CONF_RTOS_PRESENT check in crypto_misc.cpp

3e94b86

Fix UART flow control CTS/RTS

cf12140

Configure RTS pin outout to active low when RTS is disabled. This allows the peer to be able to send data if its CTS is still enabled.

Remove ROM overlaps checkup for kvstore FLASHIAP blockdevice if non d…

db22ce9

…efault values are use

Change to mbedtls_platform_zeroize()

2de0911

Change the use of the local static function `mbedtls_zeroize()` to the Mbed TLS platform function `mbedtls_platform_zeroize()`.

Disable MPU support on NRF52x platforms

309d42a

BLE: NRF52 returns tx/rx phy on phy update callback

a82b30e

STM32L0 ADC TEMPERATURE CHANNEL rework

53ff2d5

Fix Python 3 syntax in rtc host test

3526625

suppress scan timeout if we disabled scanning

9b6c139

call advertising end even if stopped by us

89e35bf

Modify IRQ handler processing without RTOS at Cortex-A ARM Compiler

6e13b75

In case of unusing RTOS, IRQ handler executes "while(1)" and it causes a program freeze. Therefore, I revised this processing. Also I added the heap setting processing and set the align to 8 byte.

Modify IRQ handler processing without RTOS at Cortex-A GCC Compiler

95c8f17

In case of unusing RTOS, IRQ handler executes "while(1)" and it causes a program freeze. Therefore, I revised this processing.

Modify IRQ handler processing without RTOS at Cortex-A IAR Compiler

5961100

In case of unusing RTOS, there is no processing against IRQ handler and it causes a linker error. Therefore, I added this processing with WEAK attribute. Also I added cmain.S file at cmsis/TARGET_CORTEX_A folder.

travis: set hypothesis to 3.88 version

5e0a2d9

Update to v4.x breaks tools, will need to be addressed separately.

0xc0170 approved these changes Jan 15, 2019

View reviewed changes

0xc0170 removed the needs: review label Jan 15, 2019

0xc0170 added the needs: review label Jan 15, 2019

Merge pull request #9384 from davidsaada/david_mbr_erase_start

a2220f3

MBRBlockDevice: When partitioning, clear the rest of first erase unit

Added pyocd depencency to resolve Travis CI issue

1f96a7c

cmonr added ready for merge and removed needs: review labels Jan 16, 2019

cmonr merged commit a8f0c33 into mbed-os-5.11 Jan 16, 2019

cmonr removed the ready for merge label Jan 16, 2019

Release candidate for mbed-os-5.11.2 #9370

Release candidate for mbed-os-5.11.2 #9370

Uh oh!

Conversation

adbridge commented Jan 14, 2019

Uh oh!

0xc0170 commented Jan 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Jan 14, 2019

Uh oh!

0xc0170 commented Jan 15, 2019

Uh oh!

0xc0170 commented Jan 15, 2019

Uh oh!

mbed-ci commented Jan 15, 2019

Test run: SUCCESS

Uh oh!

0xc0170 commented Jan 15, 2019

Uh oh!

JanneKiiskila commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SeppoTakalo commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jan 15, 2019

Uh oh!

adbridge commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Jan 16, 2019

Uh oh!

cmonr commented Jan 16, 2019

Uh oh!

cmonr commented Jan 16, 2019

Uh oh!

JanneKiiskila commented Jan 16, 2019

Uh oh!

mbed-ci commented Jan 16, 2019

Test run: SUCCESS

Uh oh!

JanneKiiskila commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jan 16, 2019

Uh oh!

adbridge commented Jan 16, 2019

Uh oh!

mbed-ci commented Jan 16, 2019

Test run: SUCCESS

Uh oh!

0xc0170 commented Jan 16, 2019

Uh oh!

Uh oh!

0xc0170 commented Jan 14, 2019 •

edited

Loading

JanneKiiskila commented Jan 15, 2019 •

edited

Loading

SeppoTakalo commented Jan 15, 2019 •

edited

Loading

adbridge commented Jan 15, 2019 •

edited

Loading

JanneKiiskila commented Jan 16, 2019 •

edited

Loading