Skip to content

Tests: USB: Fix endpoint halt test #9373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fkjagodzinski
Copy link
Member

Description

This patch fixes intermittent tests-usb_device-basic/endpoint test halt failures caused by not terminating all pending endpoint operations before repeating the test.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@c1728p9, @studavekar

@ciarmcom ciarmcom requested review from c1728p9, studavekar and a team January 14, 2019 18:00
@ciarmcom
Copy link
Member

@fkjagodzinski, thank you for your changes.
@c1728p9 @studavekar @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Jan 14, 2019

@fkjagodzinski The feature branch needs a rebase since a fix for the travis-ci/tools-py2.7 was brought in today (#9371)

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2019

@c1728p9 Can you rebase please the feature branch ?

@c1728p9 c1728p9 force-pushed the feature-hal-spec-usb-device branch from 8b6fffb to 15f9389 Compare January 17, 2019 21:16
@c1728p9
Copy link
Contributor

c1728p9 commented Jan 17, 2019

Feature branch has been updated

Abort all endpoint transfers before running the test again.
Use an updated vendor request to explicitly restart device reads.
@fkjagodzinski
Copy link
Member Author

The patch has been rebased.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2019

Please review astyle failures (related to the changes)

@fkjagodzinski
Copy link
Member Author

I've added a patch with corrected formatting. travis-ci/astyle should be happy now 😉

@cmonr
Copy link
Contributor

cmonr commented Jan 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2019

Test run: SUCCESS

Summary: 9 of 9 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit e978ba8 into ARMmbed:feature-hal-spec-usb-device Jan 21, 2019
@fkjagodzinski fkjagodzinski deleted the test_update-usb-basic branch February 1, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants