-
Notifications
You must be signed in to change notification settings - Fork 3k
Travis CI: Bind remaining python modules #9389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
requirements.txt
Outdated
@@ -20,3 +20,4 @@ six==1.11.0 | |||
git+https://github.com/armmbed/[email protected] | |||
mbed-cloud-sdk==2.0.1 | |||
icetea>=1.0.2,<1.1 | |||
idna==2.7 # Required by `icetea` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really discourage us from doing things like this, especially if we don't actually depend on it in the tools contained within this repository. Is this requirement not already present in icetea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to do this either, but as it is, Mbed OS is a lot more stricter with versions than icetea:
- https://github.com/ARMmbed/icetea/blob/master/requirements.txt
- https://github.com/ARMmbed/icetea/blob/master/dev_requirements.txt
- https://github.com/ARMmbed/icetea/blob/master/extra_requirements.txt
ARMmbed/icetea uses modules on the bleeding edge, wheras Mbed OS does not. The reason Mbed OS is squeaking along (imo) is that we cache our pip env in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Hmm. Have we ever mentioned to the icetea to at least pin their major versions? (I realize you're just the messenger here, sorry for pestering).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hadn't, but have now: ARMmbed/icetea#69
Priority was to get CI stable in Mbed OS first, as it seems that this is now affecting the release build...
As the new commits show, I'm still looking into this. It didn't help that mbedmicro/pyOCD just published v0.15, which has incompatabilities with pyYaml due to the security advisory being fixed here. |
24f6df2
to
6bd13b7
Compare
6bd13b7
to
b22b167
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm lifting my red X because I'm a little more familiar with the issue. Mbed OS doesn't have much options in this case. I'll be making a release of greentea and htrun that will make the pyocd dependency optional, so hopefully that will help with some of the issues.
f5b7cc3
to
e831516
Compare
Ready for a re-review. |
NOTE: Holding until tools are updated to make pyocd optional. Otherwise the following line needs to be added into @bridadan Will be doing that tomorrow-ish. |
Use requirements.txt to install specific versions of Travis CI python modules.
Apparently local laptop isn't fast enough for test generation, but CI is
Moved modules tied to specific versions higher, and modules with no restrictions lower.
e831516
to
e0572e7
Compare
Dependency tree: icetea > mbed_flasher > pyocd
@ARMmbed/mbed-os-maintainers One review away from being able to start CI, and have considerably more defined reqs! |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Fixes #9381
After this PR, all python modules used in CI should be loosely version-bound.
We can get stricter from here, but this should a majority of issues like this and this from happening again.
Pull request type
Reviewers