Skip to content

Travis CI: Bind remaining python modules #9389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 21, 2019

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Jan 15, 2019

Description

Fixes #9381

After this PR, all python modules used in CI should be loosely version-bound.

We can get stricter from here, but this should a majority of issues like this and this from happening again.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

requirements.txt Outdated
@@ -20,3 +20,4 @@ six==1.11.0
git+https://github.com/armmbed/[email protected]
mbed-cloud-sdk==2.0.1
icetea>=1.0.2,<1.1
idna==2.7 # Required by `icetea`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really discourage us from doing things like this, especially if we don't actually depend on it in the tools contained within this repository. Is this requirement not already present in icetea?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to do this either, but as it is, Mbed OS is a lot more stricter with versions than icetea:

ARMmbed/icetea uses modules on the bleeding edge, wheras Mbed OS does not. The reason Mbed OS is squeaking along (imo) is that we cache our pip env in CI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Hmm. Have we ever mentioned to the icetea to at least pin their major versions? (I realize you're just the messenger here, sorry for pestering).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't, but have now: ARMmbed/icetea#69

Priority was to get CI stable in Mbed OS first, as it seems that this is now affecting the release build...

@cmonr
Copy link
Contributor Author

cmonr commented Jan 15, 2019

As the new commits show, I'm still looking into this.

It didn't help that mbedmicro/pyOCD just published v0.15, which has incompatabilities with pyYaml due to the security advisory being fixed here.

@cmonr cmonr force-pushed the fixed-travisCI-python-modules branch 2 times, most recently from 24f6df2 to 6bd13b7 Compare January 15, 2019 22:13
@cmonr cmonr force-pushed the fixed-travisCI-python-modules branch from 6bd13b7 to b22b167 Compare January 16, 2019 22:06
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lifting my red X because I'm a little more familiar with the issue. Mbed OS doesn't have much options in this case. I'll be making a release of greentea and htrun that will make the pyocd dependency optional, so hopefully that will help with some of the issues.

@cmonr cmonr force-pushed the fixed-travisCI-python-modules branch from f5b7cc3 to e831516 Compare January 16, 2019 23:24
@cmonr
Copy link
Contributor Author

cmonr commented Jan 16, 2019

Ready for a re-review.

@cmonr
Copy link
Contributor Author

cmonr commented Jan 16, 2019

NOTE: Holding until tools are updated to make pyocd optional.

Otherwise the following line needs to be added into requirements.txt:
pyocd>=0.14,<0.15

@bridadan Will be doing that tomorrow-ish.

Cruz Monrreal II added 4 commits January 17, 2019 12:39
Use requirements.txt to install specific versions of Travis CI python modules.
Apparently local laptop isn't fast enough for test generation, but CI is
Moved modules tied to specific versions higher, and modules with no restrictions lower.
@cmonr cmonr force-pushed the fixed-travisCI-python-modules branch from e831516 to e0572e7 Compare January 17, 2019 18:40
Dependency tree: icetea > mbed_flasher > pyocd
@cmonr
Copy link
Contributor Author

cmonr commented Jan 17, 2019

@ARMmbed/mbed-os-maintainers One review away from being able to start CI, and have considerably more defined reqs!

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 21, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants