Fixing folder path for KVStore FILESYSTEM configuration. #9397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Travis failure is fixed on master (#9391) , if you can rebase to resolve the error |
|
@yossi2le, thank you for your changes. |
yossi2le
force-pushed
the
fix_default_storage_type
branch
from
1c396b1 to
2009322
Compare
|
Rebase done. |
|
@yossi2le When you get a chance, please rebase again. After the travis fix, there was a semantic conflict introduced when Master is green again, and that should be the last rebase you need to do. |
… in FILESYSTEM and default configuration
yossi2le
force-pushed
the
fix_default_storage_type
branch
from
2009322 to
5de92ca
Compare
|
Rebase done |
0xc0170
approved these changes
Jan 21, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix folder path for KVStore FILESYSTEM configuration and default configuration (under SD component). The folder path has always been constant "kvstore" instead of getting the value from configuration parameters.
Pull request type
Reviewers