Extended mount to check all metadata-pairs #9406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jenia81 Can you check whether this resolved the CI issues? |
davidsaada
approved these changes
Jan 17, 2019
|
@ARMmbed/mbed-os-maintainers The KCM CI passed with this PR, solving the issue https://jira.arm.com/browse/IOTSTOR-754. I think it should be merged into 5.11.2 if this is a blocker. |
0xc0170
approved these changes
Jan 17, 2019
|
We will check, 5.11.2 is going to be released soon. We will start CI asap for this one (it take a bit as the queue is big at the moment - we will monitor). |
The most common issue with using littlefs in mbed-os is when users change from littlefs->FAT->littlefs (or with MBR or similar). When this corrupts the superblock, littlefs tries to fall back to the backup superblock. However, at this point in the time the old superblock may be very out-of-date and pointing to an incorrect filesystem. There's no complete solution to a malicious modification of the filesystem (short of checking all metadata+data, a very expensive operation), but we can at least expand our validation to all of the metadata for the filesystem. This at least catches the common issues with changing between different filesystems.
|
NOTE: This PR has now been rebased. If this was made in error, feel free to force-push your local branch to restore the PR. |
cmonr
force-pushed
the
littlefs-validate-all-dirs
branch
from
20ecebd to
9d6e309
Compare
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Okay, short explanation:
@davidsaada's idea, this improves littlefs's detection of storage format encroachment (littlefs->FAT->littlefs). This is an issue with MCC<->Mbed OS integration due to some CI/example integration issues.
Long explanation:
The most common issue with using littlefs in mbed-os is when users change from littlefs->FAT->littlefs (or with MBR or similar). When this corrupts the superblock, littlefs tries to fall back to the backup superblock. However, at this point in the time the old superblock may be very out-of-date and pointing to an incorrect filesystem.
There's no complete solution to a malicious modification of the filesystem (short of checking all metadata+data, a very expensive operation), but we can at least expand our validation to all of the metadata for the filesystem. This at least catches the common issues with changing between different filesystems.
Downside: LittleFS takes a bit longer to mount
Upside: Improved user experience when trying out different filesystems
Pull request type
Reviewers
@davidsaada, @ARMmbed/mbed-os-storage