-
Notifications
You must be signed in to change notification settings - Fork 3k
DirectAccess DeviceKey: add support for default storage type #9407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DirectAccess DeviceKey: add support for default storage type #9407
Conversation
@ARMmbed/mbed-os-maintainers |
@ARMmbed/mbed-os-maintainers : travis doxy-spellcheck fails on platform/mbed_rtc_time.hErrors:
retarget verb |
@offirko, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Travis fix is in the CI , will be in today and this just need simple rebase (will notify all PR affected , so far 2 are). |
2cd7584
to
e996b7f
Compare
NOTE: This PR has now been rebased. If this was made in error, feel free to force-push your local branch to restore the PR. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Labeled for 5.11.3 (test update) , it was for 5.12 |
@0xc0170 It was marked for 5.12 because of this code addition: https://github.com/ARMmbed/mbed-os/pull/9407/files#diff-c1dac274989206951b3257f29e300a1c @adbridge @NirSonnenschein Thoughts? |
@ARMmbed/mbed-os-storage what is this fixing and what version is this targeting? |
We agreed with PDMC that they will take the code to their repo in the meantime. Will use this code from mbed OS in the next version of the bootloader. Can be delayed to 5.12 |
Description
DirectAccess DeviceKey added support for default storage type, which depends
on Component type.
Pull request type
Reviewers
@ARMmbed/mbed-os-maintainers
@ARMmbed/mbed-os-storage