Skip to content

DirectAccess DeviceKey: add support for default storage type #9407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

offirko
Copy link
Contributor

@offirko offirko commented Jan 17, 2019

Description

DirectAccess DeviceKey added support for default storage type, which depends
on Component type.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-maintainers
@ARMmbed/mbed-os-storage

@offirko
Copy link
Contributor Author

offirko commented Jan 17, 2019

@ARMmbed/mbed-os-maintainers
@ARMmbed/mbed-os-storage
Please review

@offirko
Copy link
Contributor Author

offirko commented Jan 17, 2019

@ARMmbed/mbed-os-maintainers : travis doxy-spellcheck fails on

platform/mbed_rtc_time.h

Errors:
101:/** retarget
113:/** retarget
103: secondsa
115: secondsa

  1. Is this a new feature?
  2. Why does it fail on files not related to my delivery?
  3. "retarget" seems to be a valid English word (-:
    (at least by https://www.merriam-webster.com/dictionary/retarget)

retarget verb
re·​tar·​get | \ (ˌ)rē-ˈtär-gət
retargeted; retargeting
Definition of retarget
transitive verb
: to direct (something) toward a different target

@ciarmcom ciarmcom requested review from a team January 17, 2019 08:00
@ciarmcom
Copy link
Member

@offirko, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2019

Travis fix is in the CI , will be in today and this just need simple rebase (will notify all PR affected , so far 2 are).

@0xc0170 0xc0170 changed the title DirectAccess DeviceKey added support for default storage type DirectAccess DeviceKey: add support for default storage type Jan 17, 2019
@cmonr cmonr force-pushed the offir_direct_access_handle_default_config branch from 2cd7584 to e996b7f Compare January 17, 2019 16:58
@cmonr
Copy link
Contributor

cmonr commented Jan 17, 2019

NOTE: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@cmonr
Copy link
Contributor

cmonr commented Jan 17, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2019

Labeled for 5.11.3 (test update) , it was for 5.12

@cmonr
Copy link
Contributor

cmonr commented Jan 18, 2019

@0xc0170 It was marked for 5.12 because of this code addition: https://github.com/ARMmbed/mbed-os/pull/9407/files#diff-c1dac274989206951b3257f29e300a1c

@adbridge @NirSonnenschein Thoughts?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2019

@0xc0170 It was marked for 5.12 because of this code addition: https://github.com/ARMmbed/mbed-os/pull/9407/files#diff-c1dac274989206951b3257f29e300a1c

@ARMmbed/mbed-os-storage what is this fixing and what version is this targeting?

@dannybenor
Copy link

We agreed with PDMC that they will take the code to their repo in the meantime. Will use this code from mbed OS in the next version of the bootloader. Can be delayed to 5.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants