Allow NSAPI_ERROR_UNSUPPORTED from Socket::setsockopt() #9415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return; | ||
| } | ||
|
|
||
| TEST_ASSERT_EQUAL(NSAPI_ERROR_OK, ret); | ||
| TEST_ASSERT_EQUAL(NSAPI_ERROR_OK, sock.connect(MBED_CONF_APP_ECHO_SERVER_ADDR, 9)); | ||
| // LWIP stack does not support getsockopt so the part below is commented out |
There was a problem hiding this comment.
Maybe the getsockopt test part can be implemented in the same way ?
(instead of commenting lines...)
jeromecoutant
approved these changes
Jan 17, 2019
|
@SeppoTakalo, thank you for your changes. |
VeijoPesonen
approved these changes
Jan 18, 2019
cmonr
approved these changes
Jan 18, 2019
|
CI started |
Test run: SUCCESSSummary: 9 of 9 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test case TCPSOCKET_SETSOCKOPT_KEEPALIVE_VALID currently expects
sock.setsockopt(NSAPI_SOCKET, NSAPI_KEEPALIVE, &seconds, sizeof(int))to work.This might not be true for all stacks, and documentation allows NSAPI_ERROR_UNSUPPORTED to be returned.
Fixed the testcase.
Pull request type
Reviewers
@jeromecoutant