Skip to content

tools: build_api: remove redundant initialization and fix spelling #9418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2019
Merged

tools: build_api: remove redundant initialization and fix spelling #9418

merged 1 commit into from
Jan 18, 2019

Conversation

naveenkaje
Copy link
Contributor

@naveenkaje naveenkaje commented Jan 17, 2019 •
edited
Loading

Description

memap_table is reinitialized before usage. Hence value set during initialization is overwritten before use, making it redundant.

Also, fix a spelling error.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team January 17, 2019 20:00
@ciarmcom
Copy link
Member

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

bridadan
bridadan approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches! Thanks very much for the changes!

@cmonr
Copy link
Contributor

cmonr commented Jan 18, 2019

CI started

@OPpuolitaival
Copy link
Contributor

I needed to stop some tests because CI update

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2019

Test run: FAILED

Summary: 3 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@alekla01
Copy link
Contributor

restarted stopped CI jobs

@0xc0170 0xc0170 merged commit 8f48104 into ARMmbed:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@bridadan bridadan bridadan approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@naveenkaje @ciarmcom @cmonr @OPpuolitaival @mbed-ci @alekla01 @theotherjimmy @bridadan @0xc0170