Skip to content

Update IAR Armv8M changes #9431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 4, 2019
Merged

Update IAR Armv8M changes #9431

merged 6 commits into from
Feb 4, 2019

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented Jan 18, 2019 •
edited
Loading

Description

Update IAR flags for Armv8M devices.

Cortex-M23 / Cortex-M33 CPU settings for baseline and mainline
profile (with optional floating and dsp options) updated.

Dependent on #9480

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom
Copy link
Member

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team January 18, 2019 18:00
kjbracey
kjbracey reviewed Jan 21, 2019
View reviewed changes
kjbracey
kjbracey reviewed Jan 21, 2019
View reviewed changes
kjbracey
kjbracey reviewed Jan 22, 2019
View reviewed changes
@deepikabhavnani
Copy link
Author

@kjbracey-arm @theotherjimmy - Please review

theotherjimmy
theotherjimmy approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good supposing that we're leaving the core-reworking to another PR.

@deepikabhavnani
Copy link
Author

supposing that we're leaving the core-reworking to another PR.

Yes core reworking will in another PR (by tools team :-) )

@deepikabhavnani deepikabhavnani mentioned this pull request Jan 23, 2019
Closed
cyliangtw
cyliangtw suggested changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@cyliangtw cyliangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In iar_definitions.json, M2351 part should be:
"M2351KIAAEES": {
"OGChipSelectEditMenu": "M2351 series\tNuvoton M2351 series"
}

@deepikabhavnani deepikabhavnani force-pushed the iar_armv8m_changes branch 3 times, most recently from 3d2420c to 1cb5314 Compare January 25, 2019 16:44
bridadan
bridadan reviewed Jan 25, 2019
View reviewed changes
deepikabhavnani added 5 commits January 31, 2019 16:19
Update IAR flags for Armv8M devices.
f760f72 
Cortex-M23 / Cortex-M33 CPU settings for baseline and mainline
profile (with optional floating and dsp options) updated.
M2351: Update code to support IAR 8.x builds
80f6b0e
Update cmse flag based on core_arch instead of different cores
0082474
Correct the floating+dsp options for Cortex-M processors
fdbcae3 
As per the IAR Development guide, below options for CPU are valid

1. Cortex-M33
2. Cortex-M33.no_dsp (core without integer DSP extension)
3. Cortex-M33.fp (floating-point unit with support for single precision)
4. Cortex-M33.no_se (core without support for TrustZone)
5. Cortex-M4
6. Cortex-M4F
7. Cortex-M7
8. Cortex-M7.fp.dp (floating-point unit with support for double precision)
9. Cortex-M7.fp.sp (floating-point unit with support for single precision)
Set the DSP option as E for Cortex-M33
6097095
@deepikabhavnani
Copy link
Author

Rebased to pull in dependent PR changes

bridadan
bridadan approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! One non-blocking style nit pick.

@cmonr
Copy link
Contributor

cmonr commented Feb 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 0ae6a04 into ARMmbed:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@bridadan bridadan bridadan approved these changes

@kjbracey kjbracey kjbracey approved these changes

@cyliangtw cyliangtw cyliangtw approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@deepikabhavnani @ciarmcom @cmonr @mbed-ci @theotherjimmy @bridadan @kjbracey @cyliangtw @0xc0170