Update IAR project template and revert dynamic heap support #9432

deepikabhavnani · 2019-01-18T17:09:14Z

Description

Reference template file is used from IAR8.32 installation available at path
"Embedded Workbench 8.2\arm\config\template\ConvertToIAR\template_project.ewp"
Also added trustzone configs in iar_definitions.json

Reverting dynamic heap feature till IAR 8.x is stable and supported in Mbed OS for few releases
This reverts commit 8ee29bb a645bb2 891e1f2.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

ciarmcom · 2019-01-18T18:00:35Z

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

theotherjimmy

The size of the template diff would concern me, but it looks like the settings were just re-ordered.

cmonr · 2019-01-30T22:35:20Z

This can be tested now since IAR8 should be enabled in CI (for the branch at least)

cmonr · 2019-01-31T04:48:58Z

CI started

mbed-ci · 2019-01-31T07:20:34Z

Test run: FAILED

Summary: 1 of 5 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR8

0xc0170 · 2019-01-31T13:59:26Z

@deepikabhavnani Please review the failures. I assume first PR should be to disable these targets (they need updating their binaries), thus this PR should be "preceding PR needed" ?

deepikabhavnani · 2019-02-06T13:59:16Z

Preceding PR is merged to feature branch, no dependencies now. Started CI

mbed-ci · 2019-02-06T14:52:01Z

Test run: FAILED

Summary: 3 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter
jenkins-ci/mbed-os-ci_greentea-test
jenkins-ci/mbed-os-ci_cloud-client-test

deepikabhavnani · 2019-02-06T17:16:23Z

@ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers

Please help me understand this issue ---


[Pipeline] End of Pipeline



GitHub has been notified of this commit’s build result



org.jenkinsci.plugins.workflow.cps.CpsCompilationErrorsException: startup failed:

file:/var/jenkins_home/jobs/mbed-os-ci/branches/PR-9432/builds/4/libs/mbed-os-ci/src/ciconfigurations/repositories/mbedos/FeatureARMC6BranchConfig.groovy: 13: unexpected token: toolchains @ line 13, column 45.

                                 toolchains

                                 ^
1 error

Reference template file is used from IAR8.32 installation available at path "Embedded Workbench 8.2\arm\config\template\ConvertToIAR\template_project.ewp" Also added trustzone configs in iar_definitions.json

Two new block properties available in linker configuration files: "expanding size" and "minimum size" for IAR 8.11.2 and above Sample: define block HEAP with expanding size, minimum size = 16K, alignment = 8 {}; This block will expand to consume all remaining available space in the range where it is placed. If several such blocks end up in the same range, they will share the remaining space. Cannot place a block with expanding size inside another block with expanding size, inside a block with maximum size, or inside an overlay.

Reverting this feature till IAR 8.x is stable and supported in Mbed OS for few releases 1. Revert "Add Dynamic heap support to IAR" This reverts commit 8ee29bb. 2. Revert "Splited RAM section not compatible with dynamic HEAP." This reverts commit a645bb2. 3. Revert "Add Dynamic heap support to IAR" This reverts commit 891e1f2.

NirSonnenschein · 2019-02-07T07:58:14Z

re-checking for latest changes: started CI

alekla01 · 2019-02-07T09:05:59Z

restarted CI

mbed-ci · 2019-02-07T10:58:47Z

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_cloud-client-test

deepikabhavnani · 2019-02-07T16:53:35Z

@ARMmbed/mbed-os-test-team - Please help with failure in cloud client CI

"Couldn't allocate required resources: Allocation failed"

deepikabhavnani · 2019-02-10T04:47:10Z

@ARMmbed/mbed-os-maintainers - Not sure what is issue with cloud client CI, since this PR is for feature branch can we merge it with rest of the checks green.

I need to rebase feature branch for PSOC boards after this is merged.

NirSonnenschein · 2019-02-10T22:05:45Z

Hi @deepikabhavnani , the error seems to be CI related ( resource allocation timeout) : re-running the cloud CI tests.

deepikabhavnani · 2019-02-10T23:20:11Z

Hi @deepikabhavnani , the error seems to be CI related ( resource allocation timeout) : re-running the cloud CI tests.

Error still existed after re-running test, @NirSonnenschein - Please see if someone can help with this

0xc0170 · 2019-02-11T09:22:00Z

I restarted it one more time and will report to CI team

0xc0170 · 2019-02-11T10:33:07Z

Looks like it worked ! 💯

deepikabhavnani added the parked label Jan 18, 2019

ciarmcom requested review from a team January 18, 2019 18:00

ciarmcom added the needs: review label Jan 18, 2019

theotherjimmy approved these changes Jan 18, 2019

View reviewed changes

cmonr added needs: CI and removed needs: review parked labels Jan 30, 2019

cmonr added the release-version: feature branch label Jan 30, 2019

0xc0170 added the needs: preceding PR label Jan 31, 2019

Update IAR project template as per IAR 8.32

3da74f9

Reference template file is used from IAR8.32 installation available at path "Embedded Workbench 8.2\arm\config\template\ConvertToIAR\template_project.ewp" Also added trustzone configs in iar_definitions.json

deepikabhavnani force-pushed the IAR8_template_changes branch from 0a0dc55 to 3da74f9 Compare February 6, 2019 17:59

Deepika added 2 commits February 6, 2019 12:09

deepikabhavnani changed the title ~~Update IAR project template as per IAR 8.32~~ Update IAR project template and revert dynamic heap support Feb 6, 2019

0xc0170 added ready for merge and removed needs: preceding PR needs: CI labels Feb 11, 2019

0xc0170 approved these changes Feb 11, 2019

View reviewed changes

0xc0170 merged commit 6c84b59 into ARMmbed:feature-iar8 Feb 11, 2019

0xc0170 removed the ready for merge label Feb 11, 2019

deepikabhavnani deleted the IAR8_template_changes branch February 11, 2019 12:25

kjbracey mentioned this pull request Jul 2, 2019

K64F, STM32F429: IAR linker scripts dynamic heap fix #10938

Merged

Update IAR project template and revert dynamic heap support #9432

Update IAR project template and revert dynamic heap support #9432

Uh oh!

Conversation

deepikabhavnani commented Jan 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Uh oh!

ciarmcom commented Jan 18, 2019

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Jan 30, 2019

Uh oh!

cmonr commented Jan 31, 2019

Uh oh!

mbed-ci commented Jan 31, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Jan 31, 2019

Uh oh!

deepikabhavnani commented Feb 6, 2019

Uh oh!

mbed-ci commented Feb 6, 2019

Test run: FAILED

Uh oh!

deepikabhavnani commented Feb 6, 2019

Uh oh!

NirSonnenschein commented Feb 7, 2019

Uh oh!

alekla01 commented Feb 7, 2019

Uh oh!

mbed-ci commented Feb 7, 2019

Test run: FAILED

Uh oh!

deepikabhavnani commented Feb 7, 2019

Uh oh!

deepikabhavnani commented Feb 10, 2019

Uh oh!

NirSonnenschein commented Feb 10, 2019

Uh oh!

deepikabhavnani commented Feb 10, 2019

Uh oh!

0xc0170 commented Feb 11, 2019

Uh oh!

0xc0170 commented Feb 11, 2019

Uh oh!

Uh oh!

deepikabhavnani commented Jan 18, 2019 •

edited

Loading