FPU_USED to be set based on HW FPU support + Squash commits #9437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Revert "CMSIS/RTX: __FPU_USED to be set based on HW FPU support" This reverts commit b4f5bed7e75c21927c954a50d40422b81a1de5a0. 2. Revert "CMSIS/RTX: Update Armv8M IAR 8.x assembly files - add END" This reverts commit b228cd9. 3. Revert "CMSIS/RTX: Pre-processor defines used for assembly" This reverts commit 287121f. 4. Revert "CMSIS/RTX: Patch RTX so irq_cm4f.s files work with no FPU targets" This reverts commit cc2e051.
CMSIS repo does not support pre-processor defines, hence multiple assembly files are added for secure/non-secure and floating point tools. Mbed OS tools support assembly file pre-processing, but the build system does not support multiple assembly files for each target, hence updating the assembly files. 1. Patch RTX so irq_cm4f.S files work with no FPU targets 2. Patch RTX so irq_armv8mml.S files to work with and without FPU 2. Patch RTX so irq_armv8mml.S and irq_armv8mbl.S files to work with secure and non-secure builds
deepikabhavnani
changed the title
|
@deepikabhavnani, thank you for your changes. |
kjbracey
approved these changes
Jan 21, 2019
bridadan
approved these changes
Jan 22, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 8 test jobs failed Failed test jobs:
|
|
Restarted CI |
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
SenRamakri
approved these changes
Jan 23, 2019
|
This is sitting on top of #8887 scheduled for 5.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Commit - __FPU_USED to be set based on HW FPU support
__FPU_USED flag is not set by compiler or tools, instead it should be
enabled based on HW FPU flags as done in "cmsis/TARGET_CORTEX_M/core_armv8mml.h"
Additional changes - Revert old CMSIS/RTX commits for pre-processor flags to create one single commit for importer script entry
Pull request type
Reviewers