Use dedicated PinMap for each QSPI data line #9438

c1728p9 · 2019-01-19T01:32:22Z

Description

Split PinMap_QSPI_DATA into PinMap_QSPI_DATA0 - PinMap_QSPI_DATA3. This allows pins to be selected more accurately and may be used in the future for QSPI testing.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

c1728p9 · 2019-01-19T01:41:48Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F446xE/TARGET_NUCLEO_F446RE/PeripheralPins.c

@@ -312,14 +312,25 @@ MBED_WEAK const PinMap PinMap_CAN_TD[] = {

 //*** QUADSPI ***

-MBED_WEAK const PinMap PinMap_QSPI_DATA[] = {
-    {PA_1,      QSPI_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF9_QSPI)},  // QUADSPI_BK1_IO3
-    {PB_6,      QSPI_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF10_QSPI)},  // QUADSPI_BK1_NCS


@jeromecoutant This isn't a data pin. Was QSPI always broken on this port?

Yes, no QUADSPI_BK1_IO2 pin for STM32F446RE...

jeromecoutant

Hi @c1728p9

Everything seems correct!

There was an issue with NCS pins which were added in the data list pins,
and you have corrected this! 👍

I have updated tools/targets/STM32_gen_PeripheralPins.py
I will push it after this PR merge.

jeromecoutant · 2019-01-21T10:35:32Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F446xE/TARGET_NUCLEO_F446RE/PeripheralPins.c

@@ -312,14 +312,25 @@ MBED_WEAK const PinMap PinMap_CAN_TD[] = {

 //*** QUADSPI ***

-MBED_WEAK const PinMap PinMap_QSPI_DATA[] = {
-    {PA_1,      QSPI_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF9_QSPI)},  // QUADSPI_BK1_IO3
-    {PB_6,      QSPI_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF10_QSPI)},  // QUADSPI_BK1_NCS


Yes, no QUADSPI_BK1_IO2 pin for STM32F446RE...

0xc0170 · 2019-01-22T08:05:05Z

CI started

mbed-ci · 2019-01-22T09:16:48Z

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_mbed2-build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM

jeromecoutant · 2019-01-22T12:17:43Z

Test run failed

Some updates are missing there:
https://github.com/ARMmbed/mbed-os/blob/d963536069cc41b27aaf5987b0824562b80d28d8/targets/TARGET_STM/qspi_api.c#L161

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_K82F/TARGET_FRDM/PeripheralPins.c

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_KL82Z/TARGET_FRDM/PeripheralPins.c

Split PinMap_QSPI_DATA into PinMap_QSPI_DATA0 - PinMap_QSPI_DATA3. This allows pins to be selected more accurately.

SenRamakri

LGTM

cmonr · 2019-01-22T19:30:48Z

CI started.

mbed-ci · 2019-01-22T20:20:01Z

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC6

mbed-ci · 2019-01-22T21:23:10Z

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC6

cmonr · 2019-01-23T05:00:49Z

Not sure why jenkins-ci/mbed-os-ci_build-ARMC6 is being ping'd.
@ARMmbed/mbed-os-test-team has been ping'd for assistance.

alekla01 · 2019-01-23T08:52:52Z

Restarted CI

mbed-ci · 2019-01-23T11:10:35Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 4
Build artifacts

OPpuolitaival · 2019-01-23T11:47:18Z

Now ARMC6 seems to pass

0xc0170 · 2019-01-23T13:25:05Z

[x] Functionality change

@c1728p9 This was selected for 5.12 based on PR type. If this is not the case, let us know

Use dedicated PinMap for each QSPI data line ARMmbed#9438

Use dedicated PinMap for each QSPI data line #9438

c1728p9 requested review from jeromecoutant, mmahadevan108 and SenRamakri January 19, 2019 01:32

c1728p9 commented Jan 19, 2019

View reviewed changes

0xc0170 added the needs: review label Jan 21, 2019

jeromecoutant approved these changes Jan 21, 2019

View reviewed changes

0xc0170 approved these changes Jan 21, 2019

View reviewed changes

c1728p9 mentioned this pull request Jan 22, 2019

Pinmap extensions #9449

Merged

0xc0170 added needs: CI and removed needs: review labels Jan 22, 2019

0xc0170 added needs: work and removed needs: CI labels Jan 22, 2019

mmahadevan108 reviewed Jan 22, 2019

View reviewed changes

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_K82F/TARGET_FRDM/PeripheralPins.c Outdated Show resolved Hide resolved

mmahadevan108 reviewed Jan 22, 2019

View reviewed changes

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_KL82Z/TARGET_FRDM/PeripheralPins.c Outdated Show resolved Hide resolved

Use dedicated PinMap for each QSPI data line

82b131a

Split PinMap_QSPI_DATA into PinMap_QSPI_DATA0 - PinMap_QSPI_DATA3. This allows pins to be selected more accurately.

c1728p9 force-pushed the qspi_update branch from d963536 to 82b131a Compare January 22, 2019 18:11

SenRamakri approved these changes Jan 22, 2019

View reviewed changes

mmahadevan108 approved these changes Jan 22, 2019

View reviewed changes

cmonr added needs: CI and removed needs: work labels Jan 22, 2019

NirSonnenschein added the ready for merge label Jan 23, 2019

NirSonnenschein removed the needs: CI label Jan 23, 2019

0xc0170 added release-version: 5.11.3 release-version: 5.12.0-rc1 and removed release-version: 5.11.3 labels Jan 23, 2019

0xc0170 merged commit a6509cf into ARMmbed:master Jan 23, 2019

0xc0170 removed the ready for merge label Jan 23, 2019

jeromecoutant mentioned this pull request Jan 24, 2019

STM32: PeripheralPins files update from lastest CubeMX tool version #9394

Merged

jeromecoutant added a commit to jeromecoutant/mbed that referenced this pull request Jan 24, 2019

STM32_gen_PeripheralPins.py v1.5

16028e3

Use dedicated PinMap for each QSPI data line ARMmbed#9438

adbridge pushed a commit that referenced this pull request Feb 8, 2019

STM32_gen_PeripheralPins.py v1.5

8d4b54d

Use dedicated PinMap for each QSPI data line #9438

Use dedicated PinMap for each QSPI data line #9438

Use dedicated PinMap for each QSPI data line #9438

Uh oh!

Conversation

c1728p9 commented Jan 19, 2019

Description

Pull request type

Uh oh!

c1728p9 Jan 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeromecoutant Jan 21, 2019

Choose a reason for hiding this comment

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

jeromecoutant Jan 21, 2019

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jan 22, 2019

Uh oh!

mbed-ci commented Jan 22, 2019

Test run: FAILED

Uh oh!

jeromecoutant commented Jan 22, 2019

Uh oh!

Uh oh!

Uh oh!

SenRamakri left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Jan 22, 2019

Uh oh!

mbed-ci commented Jan 22, 2019

Test run: FAILED

Uh oh!

mbed-ci commented Jan 22, 2019

Test run: FAILED

Uh oh!

cmonr commented Jan 23, 2019

Uh oh!

alekla01 commented Jan 23, 2019

Uh oh!

mbed-ci commented Jan 23, 2019

Test run: SUCCESS

Uh oh!

OPpuolitaival commented Jan 23, 2019

Uh oh!

0xc0170 commented Jan 23, 2019

Uh oh!

Uh oh!

c1728p9 Jan 19, 2019 •

edited

Loading