Skip to content

UBLOX_C030: Fix modem reset functionality #9485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

UBLOX_C030: Fix modem reset functionality #9485

merged 1 commit into from
Jan 31, 2019

Conversation

fahimalavi
Copy link
Contributor

@fahimalavi fahimalavi commented Jan 24, 2019 •
edited by 0xc0170
Loading

Description

Fixed modem reset functionality to avoid low time to trigger module switch off

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@RobMeades

RobMeades
RobMeades approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@RobMeades RobMeades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTAOD, I approve this.

@ciarmcom
Copy link
Member

@fahim-ublox, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team January 24, 2019 12:00
@fahimalavi
Copy link
Contributor Author

@screamerbg

@screamerbg
Copy link
Contributor

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 30, 2019

CI started

@0xc0170 0xc0170 changed the title Fixed modem reset functionality to avoid low time to trigger module s… UBLOX_C030: Fix modem reset functionality Jan 30, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 30, 2019

I edited the title to be <50 char , please review

@mbed-ci
Copy link

mbed-ci commented Jan 30, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 85cc30a into ARMmbed:master Jan 31, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 13, 2019

@fahim-ublox I also edited the description, we've noticed it was commented out (using <!-- -->)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@RobMeades RobMeades RobMeades approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fahimalavi @ciarmcom @screamerbg @0xc0170 @mbed-ci @RobMeades