Travis CI: Fix for license check job #9492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need a rebase once #9488 is in. |
|
Aaand found the crux of the problem. Starting a line with
Oh well. Good to know for the future. |
Somehow, having the '!' before a single command in a single line parses out the '!'.
Swapped out 'git grep' for 'grep' since it can take in a --max-count flag. The license _header_ will always be at the top. Also enabled output so that PR authors can know what the problem files are.
cmonr
force-pushed
the
travisCI-fix-license_check
branch
2 times, most recently
from
5cee9bd to
e28bf5a
Compare
|
Needed to be sure because everything was green. Did a revert of 32e247d, and pushed to test. Properly failing build: https://travis-ci.org/ARMmbed/mbed-os/jobs/484229340 |
0xc0170
approved these changes
Jan 25, 2019
|
@ARMmbed/mbed-os-test Please review |
OPpuolitaival
approved these changes
Jan 25, 2019
|
Looks good! |
|
CI started |
SeppoTakalo
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It would seem that having a '!' before a single command in a single line parses out the '!'.
Pull request type
Reviewers