Skip to content

tests-netsocket-udp UDPSOCKET_SENDTO_INVALID allow unsupported empty UDP packet #9515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2019
Merged

tests-netsocket-udp UDPSOCKET_SENDTO_INVALID allow unsupported empty UDP packet #9515

merged 2 commits into from
Jan 30, 2019

Conversation

VeijoPesonen
Copy link
Contributor

@VeijoPesonen VeijoPesonen commented Jan 28, 2019 •
edited
Loading

Description

With ESP8266 you can't send empty UDP packets. In case of TCP zero length causes immediate return with return value set as zero. UDP test case checking for empty packet fixed.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-ipcore
@mirelachirica
@TeemuKultala

@ciarmcom ciarmcom requested review from mirelachirica and a user January 28, 2019 16:01
@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@mirelachirica @TeemuKultala @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

SeppoTakalo
SeppoTakalo suggested changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole test should not be ignored, just the one value.

@cmonr
Copy link
Contributor

cmonr commented Jan 29, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 30, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit a4ed473 into ARMmbed:master Jan 30, 2019
@VeijoPesonen VeijoPesonen deleted the bugfix-tests-netsocket-udp_udpsocket_sendto_invalid branch January 30, 2019 15:24
@0xc0170 0xc0170 mentioned this pull request Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

@mirelachirica mirelachirica Awaiting requested review from mirelachirica

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@VeijoPesonen @ciarmcom @cmonr @mbed-ci @SeppoTakalo @AriParkkila @michalpasztamobica @0xc0170