Remove yotta and minar references in NCS36510 #9526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bridadan, thank you for your changes. |
0xc0170
approved these changes
Jan 29, 2019
|
Nice clean-ups 👍 |
cmonr
approved these changes
Jan 29, 2019
|
Will wait for OK from either @Team-ONSemi or @maclobdell before continuing. |
|
Any concerns @maclobdell @ARMmbed/team-onsemi ? |
|
CI started. Still waiting for reviews, but intended to get this CI-OK'd in the meanwhile |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
|
looks good to me. @danclement - are you okay with this clean up? |
maclobdell
approved these changes
Feb 4, 2019
|
@0xc0170 , as this has passed CI and seems to be well reviewed is it "ready"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doing some clean up of some old Mbed OS 3 references in this code base. The references can cause some confusion (see #6417, ARMmbed/mbed-os-5-docs#462 (comment)).
FYI @maclobdell
Pull request type
Reviewers