Skip to content

Cellular clean logging #9536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Cellular clean logging #9536

wants to merge 6 commits into from

Conversation

blind-owl
Copy link
Contributor

@blind-owl blind-owl commented Jan 29, 2019 •
edited
Loading

Description

Remove sensitive information from cellular subsystem trace logs.
- SIM pin
- APN username and password
Test coverage: 
- unit tests. All pass
- MTB_MTS_DRAGONFLY ontarget gt tests. No regression, 1 failing TC, same one as in master

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jarvte

@ciarmcom ciarmcom requested review from jarvte and a team January 29, 2019 16:00
@ciarmcom
Copy link
Member

@blind-owl, thank you for your changes.
@jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@AriParkkila
Copy link

Do not merge before the branch feature-cellular-refactor.

@cmonr
Copy link
Contributor

cmonr commented Jan 30, 2019

@AriParkkila Do we know when feature-cellular-refactor should be landing?

Asking since there's another PR as well, and we still have about three patch releases left before 5.12 code freeze

@AriParkkila
Copy link

@cmonr we are still waiting for #9457 to be merged, after that we can create PR from the feature branch to the master.

@cmonr
Copy link
Contributor

cmonr commented Jan 31, 2019

Making a note that this is now waiting on #9568

@blind-owl
Copy link
Contributor Author

This PR is obsolete and managed in #9660

@blind-owl blind-owl closed this Feb 11, 2019
@blind-owl blind-owl deleted the cellular_clean_logging branch February 11, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
needs: preceding PR release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blind-owl @ciarmcom @AriParkkila @cmonr @jarvte @adbridge