Disable reboot limit #9545
Closed
Disable reboot limit #9545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially revert commit cc5969b, which started enforcing reboot limits by correcting the comparison against zero. Now that it's working, the reboot limit is causing a problem because once it's hit the board will repeatedly halt before entering main until something corrupts or clears the error context. This is a minimal workaround to restore the broken behaviour in 5.11.2, so that the reboot limit is again not enforced.
0xc0170
approved these changes
Jan 30, 2019
|
@SenRamakri @deepikabhavnani Please review. |
deepikabhavnani
suggested changes
Jan 30, 2019
SenRamakri
reviewed
Jan 30, 2019
| @@ -216,7 +216,7 @@ mbed_error_status_t mbed_error_initialize(void) | |||
| mbed_error_reboot_callback(report_error_ctx); | |||
|
|
|||
| //We let the callback reset the error info, so check if its still valid and do the rest only if its still valid. | |||
| if (report_error_ctx->error_reboot_count > 0) { | |||
| if (report_error_ctx->error_reboot_count < 0) { | |||
There was a problem hiding this comment.
I think this essentially removes the bug fix we originally did. I think we should not commit this and focus on #9544.
SenRamakri
suggested changes
Jan 30, 2019
There was a problem hiding this comment.
I think this essentially removes the bug fix we originally did. I think we should not commit this and focus on #9544.
|
Picking #9544 over this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially revert commit cc5969b from PR #9296, which started enforcing reboot limits by correcting the comparison against zero. Now that it's working, the reboot limit is causing a problem because once it's hit the board will repeatedly halt before entering main until something corrupts or clears the error context.
This is a minimal workaround to restore the broken behaviour in 5.11.2, so that the reboot limit is again not enforced.
An alternative attempt to fix the problem properly is in PR #9544.
Pull request type
Reviewers
@SenRamakri, @TeemuKultala