mbed_die: Use wait_us not wait_ms #9547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbed_die was calling wait_ms in a critical section - this is deprecated behaviour, and caused a fatal error in debug builds, potentially leading to an infinite reboot loop if this was caused due to a reboot limit halt. Switch to using wait_us - this is safe in a critical section. This does trigger a call to mbed_warning, due to the large parameter, but that is harmless - it doesn't output anything to the console, and won't overwrite the error context if it already contains something.
0xc0170
approved these changes
Jan 30, 2019
|
Waiting for complete the review. Meanwhile CI started |
|
The warning call was actually already happening if it didn't crash, because I don't think it's worth trying to avoid it. Only real downside is if you look at the error capture, if there was no preceding error or warning you will see this Maybe something to fix later, but feels like it will be adding code for no huge benefit. |
bulislaw
approved these changes
Jan 30, 2019
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
SenRamakri
approved these changes
Jan 30, 2019
cmonr
pushed a commit
that referenced
this pull request
Jan 30, 2019
mbed_die: Use wait_us not wait_ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mbed_diewas callingwait_msin a critical section - this is deprecated behaviour, and caused a fatal error in debug builds, potentially leading to an infinite reboot loop if this was caused due to a reboot limit halt.Switch to using
wait_us- this is safe in a critical section. This does trigger a call tombed_warning, due to the large parameter, but that is harmless - it doesn't output anything to the console, and won'toverwrite the error context if it already contains something.
Pull request type
Reviewers
@SenRamakri, @TeemuKultala