BLE: fix missing scan timeout for 4.2 controllers using new API #9549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _pal_gap.scan_enable(false, false); | ||
| set_random_address_rotation(false); | ||
| } | ||
|
|
||
| if (!_scan_enabled) { |
There was a problem hiding this comment.
this should be checked first
pan-
requested changes
Jan 30, 2019
pan-
approved these changes
Jan 30, 2019
cmonr
approved these changes
Jan 30, 2019
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Controllers that don't support extended advertising don't create an event on advertising timeout and need extra support to behave correctly with the new API. This fix creates the event on on the user side making the behaviour consistent for older controllers.
Pull request type
Reviewers