Prevent double attempt to connect mesh api #9550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpasztamobica
force-pushed
the
nanostack_double_connection_attempt
branch
from
f7b8805 to
71c98ca
Compare
Socket network interface tests were failing due to DICONNECTED event being advertised, where GLOBAL_UP was expected. It turned out that nanostack receives two events: APPL_EVENT_CONNECT and APPL_BACKHAUL_INTERFACE_PHY_UP. The second attempt to connect obviously returns errors, but it also causes events to be sent out to the application. The second attempt should not take place in case the bootstrap is already started. I also fixed two reports being sent with DISCONNECT status, while they are actually something else.
michalpasztamobica
force-pushed
the
nanostack_double_connection_attempt
branch
from
71c98ca to
53a82fa
Compare
|
@michalpasztamobica, thank you for your changes. |
SeppoTakalo
approved these changes
Jan 30, 2019
cmonr
approved these changes
Jan 30, 2019
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Socket network interface tests were failing due to DICONNECTED event
being advertised, where GLOBAL_UP was expected. It turned out that
nanostack receives two events: APPL_EVENT_CONNECT and
APPL_BACKHAUL_INTERFACE_PHY_UP. The second attempt to connect obviously
returns errors, but it also causes events to be sent out to the
application. The second attempt should not take place in case the
bootstrap is already started.
I also fixed two reports being sent with DISCONNECT status, while they
are actually something else.
Pull request type
Reviewers
@SeppoTakalo
@kjbracey-arm