Modify general blockdevice tests to run all storage components #9551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannybenor
suggested changes
Jan 30, 2019
|
@theamirocohen, thank you for your changes. |
cmonr
approved these changes
Jan 30, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
All tests will run for each storage component available on device excapt for test_get_type_functionality that will run once on the default blockdevice.
theamirocohen
force-pushed
the
fix_gen_test_for_flashiap
branch
from
6debb4e to
f1f60bf
Compare
theamirocohen
changed the title
The tests were modified |
|
Ah, I thought that change was going to come later. |
|
@dannybenor Mind re-reviewing? |
dannybenor
approved these changes
Jan 31, 2019
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All tests will run for each storage component available on device excapt for test_get_type_functionality that will run once on the default blockdevice.
Pull request type
Reviewers
@ARMmbed/mbed-os-storage