Skip to content

[Wio BG96] Modified pin map #9557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2019
Merged

[Wio BG96] Modified pin map #9557

merged 1 commit into from
Feb 5, 2019

Conversation

ytsuboi
Copy link
Contributor

@ytsuboi ytsuboi commented Jan 30, 2019

Description

Fixing issue #9026

Pull request type

[ x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested a review from a team January 30, 2019 14:00
@ciarmcom
Copy link
Member

@ytsuboi, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 30, 2019

Changes looks fine but missing reason for them . Can you add to the commit message why LEDS are NC, why some pins are being commented out? How this fixes the issue? Adding new pins, changing current ones, etc?

0xc0170
0xc0170 requested changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^ my request above

@ytsuboi
[Wio BG96] Modified pin map
e19ddef 
* Remove unused Peripheral Pins definitions and add UART_1 TXD/RXD pins (fix #9026)  for the Wio BG96 board
* Remove/Fix unused PinName definitions for the Wio BG96 board from the PinNames enum
@ytsuboi
Copy link
Contributor Author

ytsuboi commented Feb 4, 2019

@0xc0170 Done same fix on #9556

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Feb 4, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 7106d0d into ARMmbed:master Feb 5, 2019
@ytsuboi ytsuboi deleted the hal-wio_bg96-9026 branch February 5, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ytsuboi @ciarmcom @0xc0170 @mbed-ci @NirSonnenschein