Skip to content

Reset internal vref buffer after an ADC conversion #9560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2019
Merged

Reset internal vref buffer after an ADC conversion #9560

merged 2 commits into from
Feb 1, 2019

Conversation

RobVlaar
Copy link

Description

Resolves: #9504

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jeromecoutant

@ciarmcom ciarmcom requested a review from a team January 30, 2019 16:00
@ciarmcom
Copy link
Member

@RobVlaar, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr cmonr requested a review from a team January 30, 2019 20:16
cmonr
cmonr suggested changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indentation

jeromecoutant
jeromecoutant approved these changes Jan 31, 2019
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I will propose the same kind of patch for all STM32 families!
Thx

@cmonr
Copy link
Contributor

cmonr commented Jan 31, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 363f35f into ARMmbed:master Feb 1, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 1, 2019

0xc0170 added release-version: 5.11.4 and removed release-version: 5.11.0-rc1 labels just now

released in the past , fixed

@jeromecoutant jeromecoutant mentioned this pull request Mar 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RobVlaar @ciarmcom @cmonr @mbed-ci @0xc0170 @jeromecoutant @r-vlaar