Skip to content

tests-netsocket-udp: UDPSOCKET_ECHOTEST_NONBLOCK fixes #9570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2019
Merged

tests-netsocket-udp: UDPSOCKET_ECHOTEST_NONBLOCK fixes #9570

merged 2 commits into from
Feb 12, 2019

Conversation

VeijoPesonen
Copy link
Contributor

Description

tests-netsocket-udp: UDPSOCKET_ECHOTEST_NONBLOCK execution time limit

Test case is allowed to take not more than a half what has been given
for the whole UDP suite.

UDP test cases reorganized so that the longest running ones are
executed last.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-ipcore
@TeemuKultala
@mirelachirica
@AriParkkila
@kivaisan

Fixes a bug where after dropping bad packets receiver doesn't restore
the socket back to non-blocking state as it's supposed to.
@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@mirelachirica @kivaisan @TeemuKultala @AriParkkila @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team January 31, 2019 14:00
@VeijoPesonen
Copy link
Contributor Author

@0xc0170 please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2019

Please fix astyle failures

Test case is allowed to take not more than a half what has been given
to the whole UDP suite.

UDP test cases reorganized so that the longest running ones are
executed last.
@VeijoPesonen
Copy link
Contributor Author

@0xc0170 astyle fixes applied.

@cmonr
Copy link
Contributor

cmonr commented Feb 11, 2019

Ah, reviewers bot got to this PR after others had already reviewed.

Thus a couple of the reviewers are supluferous.

@cmonr
Copy link
Contributor

cmonr commented Feb 11, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2019

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

#9570 (comment)

@ARMmbed/mbed-os-maintainers If y'all agree with this, feel free to merge.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 12, 2019

@VeijoPesonen As you requested explicitly these

@TeemuKultala
@mirelachirica
@AriParkkila
@kivaisan

None of above reviewed, is any required or sufficient with already reviews ?

@VeijoPesonen
Copy link
Contributor Author

@0xc0170 it was more as for their information. Enough many persons have already reviewed and approved the changes.

@0xc0170 0xc0170 merged commit 0915097 into ARMmbed:master Feb 12, 2019
@VeijoPesonen VeijoPesonen deleted the bugfix-tests-netsocket-udp_udpsocket_echotest_nonblock branch February 12, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants