-
Notifications
You must be signed in to change notification settings - Fork 3k
tests-netsocket-udp: UDPSOCKET_ECHOTEST_NONBLOCK fixes #9570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests-netsocket-udp: UDPSOCKET_ECHOTEST_NONBLOCK fixes #9570
Conversation
Fixes a bug where after dropping bad packets receiver doesn't restore the socket back to non-blocking state as it's supposed to.
@VeijoPesonen, thank you for your changes. |
@0xc0170 please review. |
Please fix astyle failures |
Test case is allowed to take not more than a half what has been given to the whole UDP suite. UDP test cases reorganized so that the longest running ones are executed last.
@0xc0170 astyle fixes applied. |
Ah, reviewers bot got to this PR after others had already reviewed. Thus a couple of the reviewers are supluferous. |
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
@ARMmbed/mbed-os-maintainers If y'all agree with this, feel free to merge. |
@VeijoPesonen As you requested explicitly these
None of above reviewed, is any required or sufficient with already reviews ? |
@0xc0170 it was more as for their information. Enough many persons have already reviewed and approved the changes. |
Description
tests-netsocket-udp: UDPSOCKET_ECHOTEST_NONBLOCK execution time limit
Test case is allowed to take not more than a half what has been given
for the whole UDP suite.
UDP test cases reorganized so that the longest running ones are
executed last.
Pull request type
Reviewers
@ARMmbed/mbed-os-ipcore
@TeemuKultala
@mirelachirica
@AriParkkila
@kivaisan