Skip to content

Greentea Socket test improvements #9582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2019

Conversation

michalpasztamobica
Copy link
Contributor

Description

  1. The bind tests were amended to take IPv6-specific steps.
  2. UDPSOCKET_RECV_TIMEOUT was occasionally failing for nanostack with an "off-by-one" error. I followed the fix applied to TCP version of this test a couple of months ago and increased the tolerance from 50 to 51. This is to much extent caused by rounding error in the assertion function, but sometimes the time really is slightly higher than 50 ms. I suppose the time measurement might be inaccurate in more ways than just the overly simplistic rounding and it makes sense to add a minimal grace period, like we did for TCP_RECV_TIMEOUT.
  3. I added a debug message that could help us check why are ASYNCHRONOUS_DNS_NON_ASYNC_AND_ASYNC and ASYNCHRONOUS_DNS_CANCEL failing from time to time. I couldn't reproduce the issue locally, it happens rather rarely.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@VeijoPesonen
@KariHaapalehto
@mtomczykmobica

@ciarmcom
Copy link
Member

ciarmcom commented Feb 1, 2019

@michalpasztamobica, thank you for your changes.
@VeijoPesonen @SeppoTakalo @KariHaapalehto @mtomczykmobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

@michalpasztamobica
Copy link
Contributor Author

@0xc0170 , this PR is already approved. Could you change the label, please?

@mbed-ci
Copy link

mbed-ci commented Feb 11, 2019

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@alekla01
Copy link
Contributor

Restarted greentea-test

@cmonr cmonr merged commit 5c4d5e3 into ARMmbed:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants