Skip to content

Improve error message for exports for OS2-only targets #9589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

bridadan
Copy link
Contributor

@bridadan bridadan commented Feb 1, 2019

Description

Addresses the issue raised in #8977.

If you try to export an Mbed OS 5 project (includes the rtos) for an OS2-only target, a "not supported" message is supposed to be printed in response to the command. This is currently what you get:

[mbed] Working path "/Users/user/Desktop/test/mbed-os-example-blinky" (program)
Scan: mbed-os-example-blinky
usage: project.py [-h] [-m MCU] [-i IDE] [-c] [-p PROGRAM] [-n PROGRAM] [-b]
                  [-L] [-S [{matrix,ides}]] [--update-packs] [-E]
                  [--build BUILD_DIR] [--source SOURCE_DIR] [-D MACROS]
                  [--profile PROFILE] [--app-config APP_CONFIG] [-z]
                  [--ignore IGNORE]
project.py: error: LPC11U68 not supported by mcuxpresso
[mbed] ERROR: "/Applications/MBEDCLI.app/Contents/Resources/miniconda/bin/python" returned error.
       Code: 2
       Path: "/Users/user/Desktop/test/mbed-os-example-blinky"
       Command: "/Applications/MBEDCLI.app/Contents/Resources/miniconda/bin/python -u /Users/user/Desktop/test/mbed-os-example-blinky/mbed-os/tools/project.py -i mcuxpresso -m LPC11U68 --source ."
       Tip: You could retry the last command with "-v" flag for verbose output

This PR changes the error message to something more relevant:

[mbed] Working path "C:\Users\bridan01\onedrive_arm\Documents\dev\mbed-os-example-blinky" (program)
Scan: mbed-os-example-blinky
[Not Supported] Target does not support mbed OS 5
[mbed] ERROR: "c:\python27\python.exe" returned error.
       Code: 1
       Path: "C:\Users\bridan01\onedrive_arm\Documents\dev\mbed-os-example-blinky"
       Command: "c:\python27\python.exe -u C:\Users\bridan01\onedrive_arm\Documents\dev\mbed-os-example-blinky\mbed-os\tools\project.py -i mcuxpresso -m LPC11U68 --source ."
       Tip: You could retry the last command with "-v" flag for verbose output
---

FYI @fluidblue

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Copy link
Contributor

@naveenkaje naveenkaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2019

Waiting for @theotherjimmy approval, meanwhile running CI

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 4, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants