Skip to content

Remove SERIAL_FC on devices which don't support it #9594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2019

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Feb 2, 2019

Description

Remove SERIAL_FC from device_has for the targets which do not have code to make use of flow control.

This PR is a subset of the pinmap work in #9449.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

The NCS36510 does not support flow control in its serial driver so it
should not have SERIAL_FC in device_has.
The ARM_IOTSS_BEID does not support flow control in its serial driver so it
should not have SERIAL_FC in device_has.
The MPS2 family does not support flow control in its serial driver so it
should not have SERIAL_FC in device_has.
@c1728p9 c1728p9 mentioned this pull request Feb 2, 2019
@ciarmcom
Copy link
Member

ciarmcom commented Feb 2, 2019

@c1728p9, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 2, 2019 18:00
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, the pinmap work is helping to catch all these? 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 4, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants