K64/ARM: Update to 2-region model for HEAP and Stack Memory #9613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, looks good to me |
0xc0170
requested changes
Feb 5, 2019
| @@ -0,0 +1,74 @@ | |||
| /* mbed Microcontroller Library - stackheap | |||
| * Copyright (C) 2019-2019 ARM Limited. All rights reserved. | |||
| * | |||
There was a problem hiding this comment.
this should contain SPDX identifier, apache 2.0
mprse
force-pushed
the
stack_heap_fix_k64f_only
branch
from
d0c6348 to
292f1a1
Compare
|
How about K66F? Would something similar be needed there? |
Solution for other targets is here: #9571 |
0xc0170
approved these changes
Feb 7, 2019
|
Shall this be closed or can go in as it is and #9571 will go separately? |
|
@ARMmbed/mbed-os-maintainers - please target to next patch release. |
|
While waiting for @deepikabhavnani approval, running CI |
|
This is needed for Bootloader - patch release. 9571 will be minor release, will rebase 9571 after this is merged, to revert the K64F change and use generic one |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is patch for Issue #9523 (K64F only).
Tested the solution on:
tests-mbedmicro-rtos-mbed-heap_and_stackandtests-mbed_hal-stack_size_unificationtests (for rtos builds).Pull request type
Reviewers
@deepikabhavnani please review.