-
Notifications
You must be signed in to change notification settings - Fork 3k
Correct the dsp flag from no_dsp to nodsp #9619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@deepikabhavnani, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why, but I still got issue:
[DEBUG] Output: arm-none-eabi-gcc: error: unrecognized argument in option '-mcpu=cortex-m33+nodsp'
Which GCC version? (I can imagine quite a new version of GCC may be needed here). |
@jeromecoutant |
starting CI |
But Musca compiles wiithout floating point, so I guess its a different story.. |
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
restarted greentea |
GCC toolchain version on my setup is: 7 2018-q2-update I can see failure for no_dsp option but nodsp is accepted.
Please scroll the list and you can see following valid options for cortex-m33: cortex-m33 cortex-m33+nodsp
|
DSP option is not available with 6 2017-q2-update version
|
Means we can't accept this without updating GCC version? |
Maybe you should update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understanding this is not supported case with current GCC, these new cores will require newer GCC.
@deepikabhavnani Might be updated this to explain the version needed for this fix to be valid? Not everyone is aware of version implications |
@deepikabhavnani By updated Martin is referring to the description. It needs more detail to cover the versions what this fix is compatible with and those it isn't. Plus any other implications. |
Officially only Arm compiler is supported for Armv8m devices. Docs and support for Armv8m will be updated when GCC compiler is updated in Mbed OS. Unlike other targets, mandatory toolchain for Armv8m on master is ARMc6. Post 5.12 release IAR 8.x will also be added for Armv8m |
Hi I could see in last doc page : https://github.com/ARMmbed/mbed-os-5-docs/blob/development/docs/tools/tools_intro.md
but no update for GCC whereas it seems that 7.x is needed for v8m ? |
GCC ARM update should be easier to do compare to the last 2 updates, should come. No update for 5.12. cc @SenRamakri |
Hi Back to this comment:
Is there any update? |
Description
Correct the dsp flag from no_dsp to nodsp.
support for nodsp flag is added by GCC compiler version 7 and above.
Pull request type
Reviewers
CC @jeromecoutant