K64, 840_DK targets; Gatt and security examples, removed LED

[ConradBraam]

Description

Updates the examples subset we build in CI to cover Gatt , Security and Periodic Advertising which touch more APIs, and removed the LED sample builds. Added NRF52840 target.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@pan-

[ciarmcom]

@ConradBraam, thank you for your changes.
@pan- @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

[pan-]

Thanks for the change @ConradBraam .
@0xc0170 Could you tell us when the examples are compiled ? Conrad was worried about time it takes. If it is acceptable, we may not remove examples and just add new ones.

[ConradBraam]

I could not find a job and logs of the actual task/job running, want to balance the additional running time for adding the other examples we have, versus just generating noise etc. So we can add the other examples for better confidence, for examples that are trivial but are often downloaded, still get coverage for finger slippages.

[bridadan]

I believe this file is maintained by @ARMmbed/mbed-os-maintainers, so I leave it to them to review.

[0xc0170]

@0xc0170 Could you tell us when the examples are compiled ? Conrad was worried about time it takes. If it is acceptable, we may not remove examples and just add new ones.

@ARMmbed/mbed-os-test please review

Build step is building examples.

[0xc0170]

DO NOT MERGE

Set as needs: work until the update

[ConradBraam]

I am holding this open because I want to try get the BLE_ExtendedAdvertising example added as well, but it's not yet mirrored in mercurial. If mirroring it is easy for @screamerbg to set up, then I can get it all in one PR.

[ConradBraam]

Added the line for
"https://os.mbed.com/teams/mbed-os-examples/code/mbed-os-example-ble-PeriodicAdvertising",
in this squashed commit. I just had to wait for the web team to mirror the repo across to hg before adding this one. All done now.

[ConradBraam]

Travis continous-integration job restarted, and passed.

[0xc0170]

CI started

[mbed-ci]

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_build-ARM
• jenkins-ci/mbed-os-ci_build-GCC_ARM
• jenkins-ci/mbed-os-ci_build-IAR

[0xc0170]

Please review build failures

[DEBUG] Errors: Error[Li005]: no definition for "main" [referenced from /builds/ws/mbed-os-ci_b
[DEBUG] Errors:           uild-IAR@5/examples/mbed-os-example-ble-privacy/./BUILD/NRF51_DK/IAR/
[DEBUG] Errors:           mbed-os/rtos/TARGET_CORTEX/mbed_boot.o]

[ConradBraam]

Not managed to find that same error - but tracked down that the mbed-os.lib was pointing to 5.11.2 not 5.11.4 as a starter that breaks this code - so I am resolving why we did not merge the lib files. Built locally I am getting error
...
[Fatal Error] main.cpp@23,0: [Pe1696]: cannot open source file "ble/gap/AdvertisingDataParser.h"
[ERROR]
#include "ble/gap/AdvertisingDataParser.h"
...
, which kind of makes sense with your "no definition for main" error now that I consider. I may end up with a chicken-egg problem. (I fixed a Jenkins job issue that tries to run the examples already yesterday) Will update once we have correct versions in place.

[cmonr]

Will update once we have correct versions in place.

@ConradBraam Any update?

[ConradBraam]

Not buildable under any compiler for NRF51, due to there not being sufficient flash. Will come back to this after some stack optimizations are delivered to allow targeting the NRF51.

[cmonr]

@ConradBraam Any thoughts on how to progress this PR, or should this be closed in the short term while said optimizations are made?

[ConradBraam]

I am blocked by some CI work, which involves moving the build&test jobs for this code from one server to another.
When that's all done this will be much easier to validate. Will raise once new CI job is runnable.