Skip to content

Fix minor bugs in secure targets file filtering #9652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2019
Merged

Fix minor bugs in secure targets file filtering #9652

merged 3 commits into from
Feb 11, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Feb 10, 2019

Description

During the TF-m bring-up we found issues with the scanning rules

This PR fixes those by:

  • Force adding mbed-os root to include dirs
  • Check source relative to ROOT on secure targets

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy @mikisch81

@orenc17 orenc17 changed the title Fix minnor bugs in secure targets file filtering Fix minor bugs in secure targets file filtering Feb 10, 2019
Check source relative to ROOT on secure targets
0ca2615 
When building secure targets, we would like compile only files that are in the the mbe-os root folder.
This Fixes an issue when sending multiple --source parameters that are all inside the mbed-os tree
@mbed-ci
Copy link

mbed-ci commented Feb 10, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6

mikisch81
mikisch81 approved these changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@mikisch81 mikisch81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciarmcom ciarmcom requested review from mikisch81, theotherjimmy and a team February 10, 2019 16:00
@ciarmcom
Copy link
Member

@orenc17, thank you for your changes.
@mikisch81 @theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

mikisch81
mikisch81 approved these changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@mikisch81 mikisch81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbed-ci
Copy link

mbed-ci commented Feb 10, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@mikisch81 mikisch81 mentioned this pull request Feb 11, 2019
Merged
@mikisch81
Copy link
Contributor

pinging @ARMmbed/mbed-os-tools @theotherjimmy

@cmonr
Copy link
Contributor

cmonr commented Feb 11, 2019

CI started (~4hrs ago)

@mbed-ci
Copy link

mbed-ci commented Feb 11, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

@cmonr cmonr merged commit f04d51b into ARMmbed:master Feb 11, 2019
@cmonr cmonr removed the needs: CI label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@mikisch81 mikisch81 mikisch81 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@orenc17 @mbed-ci @ciarmcom @mikisch81 @cmonr @theotherjimmy @0xc0170