Skip to content

Cellular: Non-IP doxygen updates #9655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2019
Merged

Cellular: Non-IP doxygen updates #9655

merged 1 commit into from
Feb 19, 2019

Conversation

mirelachirica
Copy link
Contributor

Description

Doxygen updates for cellular Non-IP implementation.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team February 11, 2019 10:00
@ciarmcom
Copy link
Member

@mirelachirica, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@mirelachirica, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 11, 2019 14:00
@ciarmcom

This comment has been minimized.

Sign in to view
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2019

Note, there's a bug in ci script (3 comments - duplication), will be fixed

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2019

Not sure why spellcheck failed for optimisation as it is in our codebase already few times? Can you review?

@SeppoTakalo
Copy link
Contributor

Is it American english only?
Probably the word should be added to the ignore.en.pws

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2019

Now fixed, optimisation to optimization 👍

@cmonr
Copy link
Contributor

cmonr commented Feb 15, 2019

@mirelachirica
s/optimisation/optimization/

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit e3bc37b into ARMmbed:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mirelachirica @ciarmcom @0xc0170 @SeppoTakalo @cmonr @mbed-ci @AnttiKauppila