Skip to content

Linker files for LPC11U68 and LPC1549 updated #9667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented Feb 11, 2019

Description

Update linker files and resolve build issue
Linker files for LPC11U68 and LPC1549 updated as Mbed OS memory model

  1. LPC1549 - Has multiple memory banks, 4K bank used for stack exclusively and 16K for Heap. Its is mbed 2 only target hence 4K for stack.
  2. LPC11U68 - Added Heap and Stack sections in linker files. Resolved build issues.

Dependent on : #9571

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mmahadevan108 @mprse

Targeted for Minor release - As dependent on #9571

Linker files for LPC11U68 and LPC1549 updated as Mbed OS memory model
1.	LPC1549
Has multiple memory banks, 4K bank used for stack exclusively and 16K for Heap
Its is mbed 2 only target hence 4K for stack.

2.	LPC11U68
Added Heap and Stack sections in linker files. Resolved build issues.
@ciarmcom ciarmcom requested review from mprse and a team February 11, 2019 22:00
@ciarmcom
Copy link
Member

@deepikabhavnani, thank you for your changes.
@mprse @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -511,6 +511,9 @@
"SLEEP",
"SPI"
],
"macros": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we adding this macro?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of linker file updates #9571, it was discovered that these 2 targets needed additional fixes. Hence separate PR was created.

LPC11U68 had build issues - to resolve that Stack and heap section was added to linker file and MBED_FAULT_HANDLER_DISABLED was disabled.

Issues were communicated and resolved over mail with NXP.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR is approved, I can cherry-pick commits and apply them on #9571, if approval for 9571 takes more than a week

@cmonr
Copy link
Contributor

cmonr commented Feb 15, 2019

#9667 (comment)

Let's move forward with that, since this PR feels ready.

@cmonr
Copy link
Contributor

cmonr commented Feb 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 15, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@deepikabhavnani
Copy link
Author

@ARMmbed/mbed-os-maintainers - We can merge this PR, this PR is in line to changes of other PR (not directly dependent). We just need to be sure that both of them are for minor release.

@cmonr cmonr merged commit 31519ef into ARMmbed:master Feb 15, 2019
@deepikabhavnani deepikabhavnani deleted the NXP_linker branch March 1, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants