-
Notifications
You must be signed in to change notification settings - Fork 3k
Linker files for LPC11U68 and LPC1549 updated #9667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Linker files for LPC11U68 and LPC1549 updated as Mbed OS memory model 1. LPC1549 Has multiple memory banks, 4K bank used for stack exclusively and 16K for Heap Its is mbed 2 only target hence 4K for stack. 2. LPC11U68 Added Heap and Stack sections in linker files. Resolved build issues.
@deepikabhavnani, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -511,6 +511,9 @@ | |||
"SLEEP", | |||
"SPI" | |||
], | |||
"macros": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we adding this macro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of linker file updates #9571, it was discovered that these 2 targets needed additional fixes. Hence separate PR was created.
LPC11U68
had build issues - to resolve that Stack and heap section was added to linker file and MBED_FAULT_HANDLER_DISABLED was disabled.
Issues were communicated and resolved over mail with NXP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this PR is approved, I can cherry-pick commits and apply them on #9571, if approval for 9571 takes more than a week
Let's move forward with that, since this PR feels ready. |
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
@ARMmbed/mbed-os-maintainers - We can merge this PR, this PR is in line to changes of other PR (not directly dependent). We just need to be sure that both of them are for minor release. |
Description
Update linker files and resolve build issue
Linker files for LPC11U68 and LPC1549 updated as Mbed OS memory model
Dependent on : #9571
Pull request type
Reviewers
@mmahadevan108 @mprse
Targeted for Minor release - As dependent on #9571