Skip to content

adding updated binary for IAR v8.32 #9682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AmmadRehmatCUS
Copy link

@AmmadRehmatCUS AmmadRehmatCUS commented Feb 12, 2019

Description

Binary for UBLOX_EVK_ODIN_W2 updated with IAR 8.32

iar_driver_wifi.txt
iar_mbed_cloud_client_example.txt
iar_mbed_wifi_example.txt
iar_mbed_wifi_example_lpo.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom
Copy link
Member

@AmmadRehmat, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 12, 2019 16:01
@ciarmcom
Copy link
Member

@AmmadRehmat, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: FAILED

Summary: 1 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR8

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

Hmmm.... This isn't the fault of the PR.

I think this failed becuase the PSOC 6 binary isn't available yet.

Actually, yeah, that's exactly why.
@deepikabhavnani Looks like the PSOC 6 target needs to be disabled for now in order for this (and other feature-iar8 PRs) to progress. At least, until the updated binary blob is available.

@deepikabhavnani
Copy link

Yes PSOC was added to branch after rebase, need to disable it for now. Will create a PR, unless some one beats me to that

@deepikabhavnani
Copy link

Dependent on : #9697

Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with binary, target should enable IAR in toolchain and 5 release_version to enable testing.

Partial revert of commit 358d939 for ODIN target

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

@AmmadRehmat Something to do with this PR while we get the other PR through: #9682 (review)

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

@AmmadRehmat Rebase when able.

@cmonr
Copy link
Contributor

cmonr commented Feb 14, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2019

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@deepikabhavnani
Copy link

K64F - failures unrelated

@cmonr
Copy link
Contributor

cmonr commented Feb 15, 2019

Hmmmm....

CI job restarted: jenkins-ci/mbed-os-ci_greentea-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants