Skip to content

enet_tasklet_disconnect() should generate event to tasklet. #9684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2019
Merged

enet_tasklet_disconnect() should generate event to tasklet. #9684

merged 1 commit into from
Feb 14, 2019

Conversation

KariHaapalehto
Copy link
Contributor

enet_tasklet_disconnect() is now generating event to ethernet_tasklet,
which will then handle it.

Description

Correction is tested manually, using K64F&Ethernet and UBLOX_ODIN_W2&Wifi

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested review from a team February 12, 2019 16:00
@ciarmcom
Copy link
Member

@KariHaapalehto, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@KariHaapalehto, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

michalpasztamobica
michalpasztamobica reviewed Feb 12, 2019
View reviewed changes
features/nanostack/mbed-mesh-api/source/include/mesh_system.h
@@ -28,7 +28,8 @@ extern "C" {
enum {
APPL_EVENT_CONNECT = 0x01,
APPL_BACKHAUL_INTERFACE_PHY_DOWN,
APPL_BACKHAUL_INTERFACE_PHY_UP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand why we don't distinguish APPL_BACKHAUL_INTERFACE_PHY_UP (interface swithced on, but cable not necessarily connected) and APPL_BACKHAUL_LINK_UP (cable connected)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KariHaapalehto ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There haven't been need for that yet, from the connection staus point of view

@KariHaapalehto
enet_tasklet_disconnect() should generate event to tasklet.
31c4013 
enet_tasklet_disconnect() is now generating event to ethernet_tasklet,
which will then handle it.
@KariHaapalehto KariHaapalehto force-pushed the ethernet_tasklet_correction branch from f8d15da to 31c4013 Compare February 13, 2019 11:57
@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

CI started whilst final review response comes in

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

Marking for 5.12.

Or @KariHaapalehto, is there a reason this should go into a patch? I wasn't able to find out why this should be generating the event.

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@KariHaapalehto
Copy link
Contributor Author

This event generation will fix the race condition of nanostack interface.
Also this will fix the issue which has been found in our internal testing https://jira.arm.com/browse/ONME-4155

@cmonr cmonr merged commit 3944165 into ARMmbed:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpasztamobica michalpasztamobica michalpasztamobica left review comments

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@KariHaapalehto @ciarmcom @cmonr @mbed-ci @0xc0170 @SeppoTakalo @michalpasztamobica