Skip to content

btle: fix build warning about unused clockConfiguration #9691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2019
Merged

btle: fix build warning about unused clockConfiguration #9691

merged 1 commit into from
Feb 14, 2019

Conversation

naveenkaje
Copy link
Contributor

@naveenkaje naveenkaje commented Feb 12, 2019 •
edited
Loading

Description

Fix the following build warning seen with both GCC and ARM_CC (built with mbed-cli v1.8.3)

[Warning] btle.cpp@115,0:  #177-D: variable "clockConfiguration"  was declared but never referenced

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team February 12, 2019 22:00
@ciarmcom
Copy link
Member

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein
Copy link
Contributor

@cmonr @0xc0170 do we need to wait for a review from mbed-os-pan on this one?

0xc0170
0xc0170 previously requested changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100644 → 100755

Please fix the file attributes

pan-
pan- approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change of permissions ? 100644 → 10075

btle: fix build warning about unused clockConfiguration
0563276 
Fix the following build warning seen with both GCC and ARM_CC
[Warning] btle.cpp@115,0:  ARMmbed#177-D: variable "clockConfiguration"  was declared but never referenced
@naveenkaje naveenkaje force-pushed the fix_btle_clockconfig_warning branch from e188061 to 0563276 Compare February 13, 2019 16:44
@naveenkaje
Copy link
Contributor Author

Why the change of permissions ? 100644 → 10075

Thanks for catching this. I found out that my editor was secretly changing the permissions under cover. I have fixed it now.

@cmonr cmonr dismissed 0xc0170’s stale review February 13, 2019 20:41

Attribute updated

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit d36ebe7 into ARMmbed:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@pan- pan- pan- approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@naveenkaje @ciarmcom @cmonr @mbed-ci @NirSonnenschein @pan- @0xc0170