Skip to content

Netsocket documentation cleanup #9698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2019
Merged

Netsocket documentation cleanup #9698

merged 1 commit into from
Feb 19, 2019
+435 −509

Conversation

michalpasztamobica
Copy link
Contributor

Description

Applying review remarks from PR #9630.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AnotherButler
@SeppoTakalo

@michalpasztamobica michalpasztamobica mentioned this pull request Feb 13, 2019
Merged
@ciarmcom ciarmcom requested review from AnotherButler, SeppoTakalo and a team February 13, 2019 10:00
@ciarmcom
Copy link
Member

@michalpasztamobica, thank you for your changes.
@AnotherButler @SeppoTakalo @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 13, 2019 10:00
@ciarmcom
Copy link
Member

@michalpasztamobica, thank you for your changes.
@AnotherButler @SeppoTakalo @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

SeppoTakalo
SeppoTakalo suggested changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small changes requested.

@michalpasztamobica michalpasztamobica force-pushed the netsocket_documentation_cleanup branch from d0b9832 to 94ee55e Compare February 13, 2019 12:48
@michalpasztamobica
Copy link
Contributor Author

@SeppoTakalo , thanks for the review. I updated according to your remarks + fixed some more errors such as non-capital letters starting sentences.

@NirSonnenschein
Copy link
Contributor

@michalpasztamobica this appears to need a rebase now, please take a look.

@michalpasztamobica michalpasztamobica force-pushed the netsocket_documentation_cleanup branch from 94ee55e to 5eaf08e Compare February 18, 2019 08:41
@michalpasztamobica
Copy link
Contributor Author

Rebase done.
@AnotherButler , please, approve if these changes are all OK now.

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

CI started whilst final review comes in

@cmonr cmonr merged commit b59b817 into ARMmbed:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@AnotherButler AnotherButler AnotherButler approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@michalpasztamobica @ciarmcom @NirSonnenschein @cmonr @0xc0170 @SeppoTakalo @AnotherButler