PSOC6: rebuild libwiced_drivers.a against mbed-os-5.11.4 #9700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vmedcy, thank you for your changes. |
This comment has been minimized.
This comment has been minimized.
This should be targeting 5.11 branch rather? |
The WICED precompiled libraries submitted with mbed-os-5.11.4 were compiled against mbed-os master branch at #57d8915a: https://github.com/ARMmbed/mbed-os/tree/57d8915a At that moment, the master branch contained commits targeting mbed-os-5.12, this prevented the libraries from functioning correctly when manually picked to mbed-os-5.11 release branch. The libraries are now compiled against #ecb3c8c: https://github.com/ARMmbed/mbed-os/tree/ecb3c8c
|
@0xc0170: yes, target is mbed-os-5.11, not master. |
SeppoTakalo
approved these changes
Feb 13, 2019
0xc0170
approved these changes
Feb 13, 2019
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
|
CI job restarted: A couple of the machines failed to initialize properly and the job was simply idling. |
|
Closing since this PR has run it's course. Result: #9719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The WICED precompiled libraries submitted with mbed-os-5.11.4
were compiled against mbed-os master branch at 57d8915.
At that moment, the master branch contained commits targeting
mbed-os-5.12, this prevented the libraries from functioning correctly
when manually picked to mbed-os-5.11 release branch.
The libraries are now compiled against ecb3c8c.
Pull request type
Reviewers
@SeppoTakalo