Reverting to original doxy configuration #9709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
pan-
approved these changes
Feb 13, 2019
|
@hasnainvirk, thank you for your changes. |
hasnainvirk
force-pushed
the
nfc_doxy
branch
from
1d05dc3 to
d5c5b4f
Compare
0xc0170
approved these changes
Feb 14, 2019
|
@pan- Can you recheck the latest commit? |
This commit essentially brings back old code. We did an attempt to resolve doxy issues with nfc durint docathlon, but it introduced more issues and yak shaving rather than being a useful exercise. Unfortunately the previous attempt got merged. This commit attempts to restore the style maintained by original developers. From here they can take over.
hasnainvirk
force-pushed
the
nfc_doxy
branch
from
d5c5b4f to
f36e896
Compare
hasnainvirk
changed the title
0xc0170
approved these changes
Feb 15, 2019
|
Ci started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to restore original style maintained and intended by the nfc developers.
Description
In a previous PR, doxy file specifier was wrongly used over license text. It needs its own block.
Pull request type
Reviewers
@pan- @0xc0170